Skip to content

Commit 997b3d4

Browse files
committed
remove commented code
1 parent 4c82bad commit 997b3d4

2 files changed

Lines changed: 0 additions & 94 deletions

File tree

packages/e2e/room.test.ts

Lines changed: 0 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,6 @@ describe('create room', () => {
1111
expect(Packet.getPayload(response, 'joinResponse')?.room?.name).toEqual('room');
1212
client.exit();
1313
});
14-
// it('create a room', async () => {
15-
// const [client] = createClients();
16-
// await client.connect();
17-
// await client.request(Messages.getLogin(client.newId(), 'batman'));
18-
// const response = await client.request(Messages.getCreateRoom(client.newId(), 'party room'));
19-
// expect(Packet.getPayload(response, 'createRoomResponse')?.room?.id).toEqual(
20-
// expect.any(String),
21-
// );
22-
// client.exit();
23-
// });
2414

2515
it('create a room, join and then leave', async () => {
2616
const [client] = createClients();
@@ -31,57 +21,4 @@ describe('create room', () => {
3121
expect(Packet.isStatusOk(leaveResponse)).toBe(true);
3222
client.exit();
3323
});
34-
35-
// it('create a room and a client join', async () => {
36-
// const [host, client] = createClients(2);
37-
// const hostId = await connectAndLogin(host);
38-
// const clientId = await connectAndLogin(client);
39-
40-
// const createRoomResponse = await host.request(
41-
// Messages.getCreateRoom(host.newId(), 'party room'),
42-
// );
43-
// const roomId = Packet.getPayload(createRoomResponse, 'createRoomResponse')?.room?.id;
44-
// expect(roomId).toBeDefined();
45-
// if (roomId) {
46-
// const [hostRoomUpdateResult, clientJoinResponse] = await Promise.all([
47-
// waitForRoomUpdate(host),
48-
// client
49-
// .request(Messages.getJoin(client.newId(), roomId))
50-
// .then((response) => Packet.getPayload(response, 'joinResponse')),
51-
// ]);
52-
53-
// expect(clientJoinResponse?.roomState?.players.length).toBe(2);
54-
// expect(clientJoinResponse?.roomState?.hostId).toBe(hostId);
55-
// expect(clientJoinResponse?.roomState?.token).toEqual(expect.any(String));
56-
// expect(hostRoomUpdateResult.token).toEqual(
57-
// expect.objectContaining({
58-
// previousToken: expect.any(String),
59-
// token: expect.any(String),
60-
// }),
61-
// );
62-
// }
63-
64-
// host.exit();
65-
// client.exit();
66-
// });
67-
68-
// it('in a room everyone leaves', async () => {
69-
// const [host, guest] = await createLoginedClients(2);
70-
// const createResponse = await host.request(Messages.getCreateRoom(host.newId(), 'room'));
71-
// const roomId = Packet.getPayload(createResponse, 'createRoomResponse')?.room?.id;
72-
// expect(roomId).toBeDefined();
73-
// if (roomId) {
74-
// await Promise.all([
75-
// waitForRoomUpdate(host),
76-
// guest.request(Messages.getJoin(guest.newId(), roomId)),
77-
// ]);
78-
// await Promise.all([
79-
// waitForRoomUpdate(guest),
80-
// host.request(Messages.getLeave(host.newId())),
81-
// ]);
82-
// await guest.request(Messages.getLeave(guest.newId()));
83-
// }
84-
// host.exit();
85-
// guest.exit();
86-
// });
8724
});

packages/server/src/player.ts

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@ export interface Player {
2222
getName(): string;
2323
getId(): PlayerId;
2424
getPlayerInfo(): priselpb.PlayerInfo;
25-
// getRoom(): Room | null;
26-
// findRoomById(roomId: RoomId): Room | null;
27-
// createRoom(config: Omit<RoomOption, 'id'>): Room;
28-
// joinRoom(roomId: RoomId): Room | null;
29-
// leaveRoom(): void;
3025
emit(packet: Packet): void;
3126
/**
3227
* Send a request to client
@@ -91,32 +86,6 @@ class PlayerImpl implements Player {
9186
id: this.id,
9287
};
9388
}
94-
// public getRoom() {
95-
// return this.room;
96-
// }
97-
// public createRoom(config: Omit<RoomOption, 'id'>) {
98-
// return newRoom(this.context, config);
99-
// }
100-
101-
// public findRoomById(roomId: RoomId) {
102-
// return this.context.rooms.get(roomId) || null;
103-
// }
104-
105-
// public joinRoom(roomId: RoomId) {
106-
// const targetRoom = this.findRoomById(roomId);
107-
// if (targetRoom) {
108-
// this.room = targetRoom;
109-
// targetRoom.addPlayer(this);
110-
// }
111-
// return this.room;
112-
// }
113-
114-
// public leaveRoom() {
115-
// if (this.room) {
116-
// this.room.removePlayer(this);
117-
// this.room = null;
118-
// }
119-
// }
12089

12190
public emit(packet: Packet) {
12291
setImmediate(emit, this.getSocket(), packet);

0 commit comments

Comments
 (0)