Add NJS-GROWTH-07 benchmark result data contract#13
Conversation
There was a problem hiding this comment.
Code Review
This pull request establishes the benchmark methodology, result schema, placeholder data, and visual proof guidelines for Neuron-JS, along with a contract test suite and necessary competitor dependencies. The review feedback correctly identifies that the results schema should require the result_kind field and suggests moving the schema file to the VitePress public directory so it can be served correctly, which cascades into updating reference paths across the documentation, READMEs, and tests.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Applies the remaining code-review changes that the test suite already expected but the source did not satisfy: - Move results.schema.json into docs/public/benchmarks/ so VitePress serves it at /neuron-js/benchmarks/results.schema.json (matching its $id); previously it lived in a content dir and was never served and the contract test could not find it. - Add result_kind to the per-row required array in the schema. - Update path references in methodology.md and benchmarks/README.md, and fix the index.md link to the served public URL. Fixes the failing CI quality job (3 benchmark-contract tests). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Summary
Adds the NJS-GROWTH-07 benchmark/result-data contract for downstream proof assets without publishing or implying measured benchmark claims.
Deliverables
docs/benchmarks/results.schema.json: machine-readable benchmark result schema with stable field names, units, and source explanations.benchmarks/sample-results.placeholder.json: deterministic placeholder fixture markedresult_kind: placeholder_sample,is_placeholder: true, andclaims_allowed: false.docs/benchmarks/methodology.md: competitor set, scenario matrix, input-size matrix, metric definitions, and placeholder-data policy.tests/contracts/benchmark-contract.test.ts: regression coverage for the schema, sample placeholder guardrails, competitor/scenario/input matrix, and VitePress discovery link.Validation
yarn lint✅yarn test✅ 11 files / 59 testsyarn build✅yarn docs:build✅yarn examples✅Guardrails