Remove dynamic dispatch from field API methods#53
Merged
SebastianM-C merged 4 commits intoOct 21, 2025
Merged
Conversation
This removes the Symbol to Val conversion methods that were causing
dynamic dispatch in E(), B(), and EB() functions. Now only Val{:real}
and Val{:complex} are accepted, which eliminates the performance
regression from dynamic dispatch.
Breaking change: Users must now call these functions with Val(:real)
or Val(:complex) instead of :real or :complex symbols.
Changes:
- Remove E(r, t, laser, symbol::Symbol) method
- Remove B(r, t, laser, symbol::Symbol) method
- Remove EB(r, t, laser, symbol::Symbol) method
- Update internal calls to use Val(:real) and Val(:complex)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Added comprehensive JET tests for all field API methods (E, B, EB) with both Val(:real) and Val(:complex) for GaussLaser and LaguerreGaussLaser. This ensures we maintain type stability and catch any performance regressions from dynamic dispatch. Changes: - Add JET to test dependencies in Project.toml - Create test/qa.jl with @test_opt for all field methods - Add QA test suite to runtests.jl 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Changes: - Replace 'nightly' with 'pre' in Julia version matrix - Upgrade julia-actions/setup-julia from v1 to v2 in both test and docs jobs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Breaking changes in this release: - Removed Symbol to Val conversion methods for E(), B(), and EB() - Users must now use Val(:real) or Val(:complex) explicitly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
SebastianM-C
deleted the
claude/remove-dynamic-dispatch-011CUJwoj6txR9t2cRfxL6np
branch
Owner
Author
|
@JuliaRegistrator register release_notes=""" Breaking Changes
Performance Improvements
|
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the Symbol to Val conversion methods that were causing dynamic dispatch in E(), B(), and EB() functions. Now only Val{:real} and Val{:complex} are accepted, which eliminates the performance regression from dynamic dispatch.
Breaking change: Users must now call these functions with Val(:real) or Val(:complex) instead of :real or :complex symbols.
Changes:
🤖 Generated with Claude Code