Conversation
Collaborator
Author
|
I've also moved from deprecated drommond1F1 to __1F_1 from HypergeomtricFunctions. And made HypergeometricFunctions an import, as suggested by #48. Should probably just be a direct import instead of a constant. |
Attempt 2 at fixing the CI.
Update docs derived.
Fixed typo.
Owner
SebastianM-C
left a comment
SebastianM-C
left a comment
There was a problem hiding this comment.
Thanks, it makes sense to expose the complex versions too. I've left a few comments, but mainly we should be using the complex version internally instead of copying the code.
Co-authored-by: Sebastian Micluța-Câmpeanu <31181429+SebastianM-C@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added method overloads to allow for returning complex fields on request.
TODO: Document
E(r, t, laser, :complex),E(r, t, laser, :real)andE(r, t, laser). I've also madeEBpublic and can return complex values on demand through the same pattern.