fix: support enum fields in query and path parameters

[shavaizknz]

Summary

• Add protoreflect.EnumKind case to convertStringToFieldValue so enum fields work as query/path parameters
• Support both numeric values (e.g. 3) and proto enum name strings (e.g. TIMEFRAME_ALL) via the field's enum descriptor
• Change function signature from (string, protoreflect.Kind) to (string, protoreflect.FieldDescriptor) to enable enum name lookup

Fixes #151

Test plan

• All existing golden file tests pass (UPDATE_GOLDEN=1 go test to regenerate)
• All internal/... tests pass
• Verify with a proto service that uses an enum query parameter (e.g. ?timeframe=TIMEFRAME_ALL)
• Verify numeric enum values also work (e.g. ?timeframe=3)

🤖 Generated with Claude Code

[shavaizknz]

Latest push addresses the review feedback:

Changes:

• Added code comment explaining why unknown enum numbers are accepted (proto3 forward-compat / protojson alignment)
• Improved error message to include enum type: invalid value "FOO" for enum Timeframe
• isPathParamCompatible() now accepts EnumKind
• Empty query param values (?param=) filtered as unset
• Fixed TS server generator: enum path params now cast (as Region), repeated enum query params cast (as Region[]) — pre-existing gap exposed by the new test proto

Tests (11 runtime cases in internal/httpgen/enum_query_test.go):

1. Query: valid enum name → 200
2. Query: valid numeric → 200
3. Query: UNSPECIFIED/0 → 200
4. Query: unknown name → 400, violations with enum type in message
5. Query: unknown number → 200 (forward-compat)
6. Query: wrong case → 400
7. Query: empty string → treated as unset
8. Query: repeated enum (?regions=A&regions=B) → both parsed
   9a. Path: valid name → 200
   9b. Path: valid number → 200
   9c. Path: unknown name → 400

Example: examples/enum-params/ — portfolio service with Timeframe query param and AssetClass path param

Docs: Added "Supported Query & Path Parameter Types" section to http-generation.md with enum documentation, and added enum to query params example in client-generation.md

Co-authored-by: Claude Code

[shavaizknz]

Test results after rebasing on main:

Passing (6/7 packages):

• internal/annotations ✓
• internal/clientgen ✓
• internal/openapiv3 ✓
• internal/tsclientgen ✓
• internal/tscommon ✓
• internal/tsservergen ✓

Failing (1/7 packages):

• internal/httpgen — 7 pre-existing consistency test failures (UnmarshalJSON vs UnmarshalJSONSebuf mismatch between go-http and go-client generators). These same tests fail on main at commit 4beef2b — not introduced by this PR.

All enum-specific tests pass, including the 11 runtime test cases in TestEnumQueryAndPathParams and all golden file comparisons.

Co-authored-by: Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 0% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.92%. Comparing base (1b08604) to head (ae34205).

Files with missing lines	Patch %	Lines
internal/tsservergen/generator.go	0.00%	66 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##            main    #152      +/-   ##
========================================
- Coverage   4.97%   4.92%   -0.06%     
========================================
  Files         35      35              
  Lines       4443    4490      +47     
========================================
  Hits         221     221              
- Misses      4218    4265      +47     
  Partials       4       4              

Flag	Coverage Δ
unittests	4.92% <0.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[SebastienMelki]

Hi @shavaizknz thanks for the fix! Can you please review the linting issue happening on the PR? Thank you

[shavaizknz]

Linting issues resolved in the latest push. Reproduced locally with golangci-lint run and fixed:

• goimports formatting in enum_query_test.go and tsservergen/generator.go
• golines line-length in httpgen/generator.go and tsservergen/generator.go
• govet shadow warnings in enum_query_test.go (renamed inner err to mkErr/writeErr)

All 9 actual CI checks now pass: Build Binaries, Coverage Analysis, Coverage Status Check, Integration Tests, Lint & Code Quality, Test (Go 1.26 macos + ubuntu), codecov/patch, codecov/project.

The only failure is "PR Status Summary", but checking the job details shows it fails with Resource not accessible by integration (HTTP 403) when trying to post a comment — not a code/test failure. This is likely because the source branch is on my fork and I wasn't a collaborator when the PR was opened, so the GitHub Actions token has limited write permissions for comments on this PR.

Co-authored-by: Claude Code