Skip to content

Commit 9874fc8

Browse files
authored
Merge pull request #25 from dlubitz/task/php84
TASK: PHP8.4 compatibility
2 parents 2856bd2 + c1a66e1 commit 9874fc8

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

Classes/Controller/TerminalCommandController.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,10 @@ public function getCommandsAction(): void
9090
*/
9191
public function invokeCommandAction(
9292
string $commandName,
93-
string $argument = null,
94-
Node $siteNode = null,
95-
Node $documentNode = null,
96-
Node $focusedNode = null
93+
?string $argument = null,
94+
?Node $siteNode = null,
95+
?Node $documentNode = null,
96+
?Node $focusedNode = null
9797
): void
9898
{
9999
$this->response->setContentType('application/json');

Classes/Domain/CommandContext.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public function getSiteNode(): ?Node
3737
return $this->siteNode;
3838
}
3939

40-
public function withSiteNode(Node $siteNode = null): CommandContext
40+
public function withSiteNode(?Node $siteNode = null): CommandContext
4141
{
4242
$instance = clone $this;
4343
$instance->siteNode = $siteNode;
@@ -49,7 +49,7 @@ public function getDocumentNode(): ?Node
4949
return $this->documentNode;
5050
}
5151

52-
public function withDocumentNode(Node $documentNode = null): CommandContext
52+
public function withDocumentNode(?Node $documentNode = null): CommandContext
5353
{
5454
$instance = clone $this;
5555
$instance->documentNode = $documentNode;
@@ -61,7 +61,7 @@ public function getFocusedNode(): ?Node
6161
return $this->focusedNode;
6262
}
6363

64-
public function withFocusedNode(Node $focusedNode = null): CommandContext
64+
public function withFocusedNode(?Node $focusedNode = null): CommandContext
6565
{
6666
$instance = clone $this;
6767
$instance->focusedNode = $focusedNode;

0 commit comments

Comments
 (0)