Skip to content

TASK: PHP8.4 compatibility #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sebobo merged 1 commit into from
Feb 27, 2026
Merged

TASK: PHP8.4 compatibility #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Classes/Controller/TerminalCommandController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ public function getCommandsAction(): void
*/
public function invokeCommandAction(
string $commandName,
string $argument = null,
Node $siteNode = null,
Node $documentNode = null,
Node $focusedNode = null
?string $argument = null,
?Node $siteNode = null,
?Node $documentNode = null,
?Node $focusedNode = null
): void
{
$this->response->setContentType('application/json');
Expand Down
6 changes: 3 additions & 3 deletions Classes/Domain/CommandContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function getSiteNode(): ?Node
return $this->siteNode;
}

public function withSiteNode(Node $siteNode = null): CommandContext
public function withSiteNode(?Node $siteNode = null): CommandContext
{
$instance = clone $this;
$instance->siteNode = $siteNode;
Expand All @@ -49,7 +49,7 @@ public function getDocumentNode(): ?Node
return $this->documentNode;
}

public function withDocumentNode(Node $documentNode = null): CommandContext
public function withDocumentNode(?Node $documentNode = null): CommandContext
{
$instance = clone $this;
$instance->documentNode = $documentNode;
Expand All @@ -61,7 +61,7 @@ public function getFocusedNode(): ?Node
return $this->focusedNode;
}

public function withFocusedNode(Node $focusedNode = null): CommandContext
public function withFocusedNode(?Node $focusedNode = null): CommandContext
{
$instance = clone $this;
$instance->focusedNode = $focusedNode;
Expand Down