Skip to content

Commit 7dd0917

Browse files
ksroda-saclaude
andcommitted
chore(ci): address copilot feedback on dependabot/android workflow
- test-android.yml: install Android SDK 36 / build-tools 36.0.0 to match the RN samples' compileSdkVersion = 36 (was 35, would fail clean runner) - dependabot.yml: clarify that RN auto-merge exclusion is directory-based in the auto-merge workflow, not label-based Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent b28e822 commit 7dd0917

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/dependabot.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,11 @@ updates:
9090
commit-message:
9191
prefix: "deps"
9292

93-
# React Native samples — labelled "manual-review" so the auto-merge workflow
94-
# skips them. Dep bumps here can break native autolinking / API shapes that
95-
# `tsc --noEmit` doesn't catch; require human eyes on every update.
93+
# React Native samples — the auto-merge workflow excludes
94+
# /samples/react-native/* by directory match, so bumps here always require
95+
# human review. Dep bumps can break native autolinking / API shapes that
96+
# `tsc --noEmit` doesn't catch. The "manual-review" label is informational
97+
# only (the workflow filter is directory-based, not label-based).
9698
- package-ecosystem: "npm"
9799
directory: "/samples/react-native/login-pkce"
98100
schedule:

.github/workflows/test-android.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
- name: Set up Android SDK
5454
uses: android-actions/setup-android@v3
5555
with:
56-
packages: "platform-tools platforms;android-35 build-tools;35.0.0"
56+
packages: "platform-tools platforms;android-36 build-tools;36.0.0"
5757

5858
# React Native samples need their JS deps installed first so autolinking
5959
# can resolve native modules from node_modules. Detect by walking up to

0 commit comments

Comments
 (0)