Skip to content

Commit bf8a2e0

Browse files
ksroda-saclaude
andauthored
fix(ci): always notify ciam-core on push to main (#159)
* fix(ci): always notify ciam-core on push to main The dispatch was previously gated on `steps.diff.outputs.changed == 'true'`, but the PR-side "Verify no drift" check enforces that snippets.json / snippet-manifest.yaml are regenerated and committed before merge. The post-merge diff is therefore almost always clean — meaning the dispatch to ciam-core was effectively never firing. Fire the dispatch unconditionally. The downstream sync workflow uses peter-evans/create-pull-request, which is idempotent: it opens or updates a PR only when the destination actually differs from the source. The committing-of-regenerated-artifacts step keeps its diff gate so we don't pollute history with empty commits. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * remove comment * chore: allow CIAM UI team to also approve .github/ changes Previously only @SecureAuthCorp/devops could approve PRs touching .github/ (Actions workflows, dependabot config, this CODEOWNERS file). Add @SecureAuthCorp/team-eng-ciam-ui-write to the same rule so either team can sign off — the UI team owns most of the workflow files that support the quickstart samples anyway. GitHub treats multiple owners on a single CODEOWNERS rule as OR semantics: any one of the listed teams' approvals satisfies the requirement. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 7b55198 commit bf8a2e0

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

.github/CODEOWNERS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@
88
**/pom.xml @ksroda-sa
99
**/*.csproj @ksroda-sa
1010

11-
# GitHub Actions and CI config
12-
.github/ @SecureAuthCorp/devops
11+
# GitHub Actions and CI config — approval from either team is sufficient
12+
.github/ @SecureAuthCorp/devops @SecureAuthCorp/team-eng-ciam-ui-write

.github/workflows/extract.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ jobs:
9191
git push
9292
9393
- name: Notify ciam-core of snippet changes
94-
if: steps.diff.outputs.changed == 'true'
9594
run: |
9695
gh api repos/SecureAuthCorp/ciam-core/dispatches \
9796
-f event_type=quickstart-snippets-updated \

0 commit comments

Comments
 (0)