test: verify RN Android watch-root walk-up in find-projects#162
Closed
ksroda-sa wants to merge 1 commit into
Closed
test: verify RN Android watch-root walk-up in find-projects#162ksroda-sa wants to merge 1 commit into
ksroda-sa wants to merge 1 commit into
Conversation
ksroda-sa
force-pushed
the
test/rn-android-watch-root-verify
branch
3 times, most recently
from
May 14, 2026 08:18
e0c7ada to
f7084cd
Compare
ksroda-sa
force-pushed
the
test/rn-android-watch-root-verify
branch
from
May 14, 2026 08:22
f7084cd to
bda0acc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test PR — not for merge. Verifies the most subtle case in the path-aware find-projects logic:
What this changes
Adds a one-line cross-link in samples/react-native/login-pkce/README.md. The change lives at the RN sample root, not in
samples/react-native/login-pkce/android/.Expected behavior
test-android["samples/react-native/login-pkce/android"](walk_root finds package.json one level up → matches README)assembleDebugfor that one projectAndroid tests passed✅test-js["samples/react-native/login-pkce"](direct match — README is in the project subtree)yarn install+ build for that one projectJS tests passed✅test-ios[](no iOS sample touched)iOS tests passed✅ viaresult == 'skipped'test-dotnet[].NET tests passed✅ via skiptest-java[]Java tests passed✅ via skipextractvalidatevalidate✅What this PR exercises
gradlewlives atsamples/react-native/login-pkce/android/gradlew, but the walk-up findssamples/react-native/login-pkce/package.jsonand uses that as the watch_root. README change there must include the Android project in the matrix.samples/react-native/token-refreshshould NOT appear in either matrix (only login-pkce's subtree was touched).samples/android/*) should NOT appear in test-android's matrix (their watch_root is the project dir itself, README is not in their subtree).result != 'success' && result != 'skipped'branch is false → aggregator job exits cleanly → required check is green.Test result observation
If aggregators all green and
test-androidmatrix contains exactly one entry (samples/react-native/login-pkce/android), the watch-root logic is verified end-to-end and we can close this PR.If the matrix is empty or contains other unrelated projects, there's a regression to investigate.
🤖 Generated with Claude Code