Open
Conversation
… setting dialogs
…ccess the internal `OptionSet` directly instead of calling `getState()`
… Failed during issue submission #920
There was a problem hiding this comment.
Pull request overview
Bugfix-focused PR for the v4.2.1 release line, addressing stability issues in settings access, issue submission, and link handling.
Changes:
- Refactored
CsvEditorSettingsgetters to read from the internalOptionSetdirectly (instead ofgetState()). - Hardened GitHub issue submission by extracting and testing a non-empty “search needle” derivation to avoid GitHub 422 validation failures.
- Adjusted
CsvPlugin.openLinkthreading behavior and updated the changelog/test suite accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/test/java/net/seesharpsoft/intellij/plugins/csv/settings/CsvEditorSettingsProviderTest.java |
Simplifies testApply assertions (but currently reduces verification and cleanup). |
src/test/java/net/seesharpsoft/intellij/plugins/csv/CsvGithubIssueSubmitterTest.java |
Adds unit coverage for searchExistingIssuesNeedle(...). |
src/main/java/net/seesharpsoft/intellij/plugins/csv/settings/CsvEditorSettings.java |
Switches many getters from getState() to direct myOptions access. |
src/main/java/net/seesharpsoft/intellij/plugins/csv/CsvPlugin.java |
Changes threading strategy when opening settings vs. browsing links. |
src/main/java/net/seesharpsoft/intellij/plugins/csv/CsvGithubIssueSubmitter.java |
Introduces searchExistingIssuesNeedle(...) and uses it in search. |
CHANGELOG.md |
Documents the fixes/issues for v4.2.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/net/seesharpsoft/intellij/plugins/csv/settings/CsvEditorSettings.java
Show resolved
Hide resolved
src/main/java/net/seesharpsoft/intellij/plugins/csv/settings/CsvEditorSettings.java
Show resolved
Hide resolved
src/test/java/net/seesharpsoft/intellij/plugins/csv/settings/CsvEditorSettingsProviderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/seesharpsoft/intellij/plugins/csv/CsvGithubIssueSubmitterTest.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.