Skip to content

Bugfixes for v421#979

Open
SeeSharpSoft wants to merge 5 commits intomainfrom
v421
Open

Bugfixes for v421#979
SeeSharpSoft wants to merge 5 commits intomainfrom
v421

Conversation

@SeeSharpSoft
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bugfix-focused PR for the v4.2.1 release line, addressing stability issues in settings access, issue submission, and link handling.

Changes:

  • Refactored CsvEditorSettings getters to read from the internal OptionSet directly (instead of getState()).
  • Hardened GitHub issue submission by extracting and testing a non-empty “search needle” derivation to avoid GitHub 422 validation failures.
  • Adjusted CsvPlugin.openLink threading behavior and updated the changelog/test suite accordingly.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/test/java/net/seesharpsoft/intellij/plugins/csv/settings/CsvEditorSettingsProviderTest.java Simplifies testApply assertions (but currently reduces verification and cleanup).
src/test/java/net/seesharpsoft/intellij/plugins/csv/CsvGithubIssueSubmitterTest.java Adds unit coverage for searchExistingIssuesNeedle(...).
src/main/java/net/seesharpsoft/intellij/plugins/csv/settings/CsvEditorSettings.java Switches many getters from getState() to direct myOptions access.
src/main/java/net/seesharpsoft/intellij/plugins/csv/CsvPlugin.java Changes threading strategy when opening settings vs. browsing links.
src/main/java/net/seesharpsoft/intellij/plugins/csv/CsvGithubIssueSubmitter.java Introduces searchExistingIssuesNeedle(...) and uses it in search.
CHANGELOG.md Documents the fixes/issues for v4.2.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants