Update SettingsDefinition to current dev (v0.8.7)#10
Merged
newtonick merged 1 commit intoJul 13, 2026
Merged
Conversation
Regenerated docs/index.html from the v0.8.7 SettingsDefinition and bumped the src/seedsigner submodule pointer to current dev (e0a80d4). Settings changes since the prior pin (3455aa4): - Add 13 languages: cs, el, fa, hi, id, ko, no, pl, pt_BR, ru, th, tr, vi - Add 'Xpub QR format' setting (xpub_qr: urca/sta/spl) - Remove 'Coordinator software' setting (coords) - Remove 'Xpub export' setting (xpub_export)
Collaborator
|
ACK, reviewed and tested locally. I was able to generate a byte for byte identical index.html and saw the new languages and Xpub QR format settings that replaced the list of coordinators. |
newtonick
moved this from 0.8.7 Needs Code Review
to 0.8.7 Merged
in @SeedSigner Development Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates
docs/index.htmlfrom SeedSigner's v0.8.7SettingsDefinitionand bumps thesrc/seedsignersubmodule pointer to currentdev(e0a80d4). The previously pinned commit (3455aa4) is now 159 commits behinddev, so the hosted generator is missing the v0.8.7 settings.Settings changes captured
Added
cs,el,fa,hi,id,ko,no,pl,pt_BR,ru,th,tr,vixpub_qr:urca/sta/spl)Removed
coords) — replaced upstream by the xpub QR typexpub_export) — eliminated upstreamHow it was generated
Followed the standard flow in
docs/developers.md: pointedsrc/seedsignerat currentdev, then ransrc/extract_settings.pyto renderdocs/index.htmlfromSettingsDefinition.to_dict(). The only changes in this PR are the regenerateddocs/index.htmland the submodule pointer bump.