Skip to content

Update seedsigner-translations submodule to latest dev (708961)#932

Merged
newtonick merged 2 commits into
SeedSigner:devfrom
Chaitanya-Keyal:chore/update-translations-submodule
Jun 10, 2026
Merged

Update seedsigner-translations submodule to latest dev (708961)#932
newtonick merged 2 commits into
SeedSigner:devfrom
Chaitanya-Keyal:chore/update-translations-submodule

Conversation

@Chaitanya-Keyal

@Chaitanya-Keyal Chaitanya-Keyal commented May 4, 2026

Copy link
Copy Markdown
Contributor

Description

This PR updates the seedsigner-translations submodule to the latest dev commit (SeedSigner/seedsigner-translations@708961).

Additionally, this PR fixes CI run failures that emerged with this submodule update. In recent changes to the seedsigner-translations repo, the compiled .mo files were removed from version control. Because the tests workflow in this repository did not have the compile_catalog step (unlike our other workflows), the .mo files were entirely absent during tests.

Additional Information / CI Changes

  • Added setuptools to requirements-l10n.txt: Our translation compilation relies on setup.py, but starting in Python 3.12, setuptools is no longer bundled by default via ensurepip/venv. Adding it explicitly ensures the Python 3.12+ matrix builds succeed without throwing ModuleNotFoundError: No module named 'setuptools'.
  • Compile Catalog Step: Updated tests.yml to explicitly install l10n/requirements-l10n.txt and run python setup.py compile_catalog right before executing the tests to generate the missing .mo files.
  • Editable Install Mode: Changed the installation command to pip install -e . (editable mode). This ensures that the newly compiled .mo files generated directly inside the src directory are immediately available and resolvable by pytest.

All these changes make the tests workflow in this repo similar to the translations repo's workflow.


This pull request is categorized as a:

  • Other

Checklist

I ran pytest locally

  • All tests passed before submitting the PR

I included screenshots of any new or modified screens

  • N/A

I added or updated tests

  • N/A

I tested this PR hands-on on the following platform(s):


I have reviewed these notes:

  • Keep your changes limited in scope.
  • If you uncover other issues or improvements along the way, ideally submit those as a separate PR.
  • The more complicated the PR, the harder it is to review, test, and merge.
  • We appreciate your efforts, but we're a small team of volunteers so PR review can be a very slow process.
  • Please only "@" mention a contributor if their input is truly needed to enable further progress.
  • I understand

@Chaitanya-Keyal
Chaitanya-Keyal force-pushed the chore/update-translations-submodule branch from 9c3f3e7 to 1e09257 Compare June 1, 2026 18:38
@Chaitanya-Keyal Chaitanya-Keyal changed the title Update seedsigner-translations submodule to latest dev (9a76a81) Update seedsigner-translations submodule to latest dev (e7ff6b) Jun 1, 2026
@Chaitanya-Keyal Chaitanya-Keyal changed the title Update seedsigner-translations submodule to latest dev (e7ff6b) Update seedsigner-translations submodule to latest dev (e7ff6b5) Jun 1, 2026
@kdmukai kdmukai moved this from 0.8.7 Needs Code Review to 0.8.7 In Progress in @SeedSigner Development Board Jun 4, 2026
@Chaitanya-Keyal
Chaitanya-Keyal force-pushed the chore/update-translations-submodule branch from 1e09257 to 3d8af16 Compare June 5, 2026 04:35
@Chaitanya-Keyal Chaitanya-Keyal changed the title Update seedsigner-translations submodule to latest dev (e7ff6b5) Update seedsigner-translations submodule to latest dev (708961) Jun 5, 2026
@Chaitanya-Keyal Chaitanya-Keyal moved this from 0.8.7 In Progress to 0.8.7 Needs Code Review in @SeedSigner Development Board Jun 5, 2026
@newtonick

Copy link
Copy Markdown
Collaborator

I just realized I completely duplicated this PR via #937. I'm going to merge this PR and close out mine.

@Chaitanya-Keyal thank you for your dedication and contributions!

@newtonick

Copy link
Copy Markdown
Collaborator

ACK

@newtonick
newtonick merged commit 6cd085e into SeedSigner:dev Jun 10, 2026
2 checks passed
@newtonick newtonick moved this from 0.8.7 Needs Code Review to 0.8.7 Merged in @SeedSigner Development Board Jun 10, 2026
@Chaitanya-Keyal
Chaitanya-Keyal deleted the chore/update-translations-submodule branch June 20, 2026 13:05
@newtonick newtonick added this to the 0.8.7 milestone Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 0.8.7 Merged

Development

Successfully merging this pull request may close these issues.

3 participants