Skip to content

test: include agy in OPTIONAL_EXECUTION_PROVIDERS assertion (hotfix #217 CI break)#218

Merged
SeemSeam merged 1 commit into
SeemSeam:mainfrom
LeoLin990405:hotfix/agy-execution-registry-test
Jun 1, 2026
Merged

test: include agy in OPTIONAL_EXECUTION_PROVIDERS assertion (hotfix #217 CI break)#218
SeemSeam merged 1 commit into
SeemSeam:mainfrom
LeoLin990405:hotfix/agy-execution-registry-test

Conversation

@LeoLin990405

Copy link
Copy Markdown
Contributor

Summary

Hotfix for the CI breakage on main after #217 merged. One test
expected the old OPTIONAL_EXECUTION_PROVIDERS set; #217 added agy
to OPTIONAL_PROVIDER_NAMES (which the execution registry aliases),
so the test needs to be updated.

Broken CI run (8/11 jobs failed, all with the same single
failure):
https://github.com/SeemSeam/claude_codex_bridge/actions/runs/26735236338

test/test_v2_execution_registry.py:13: in test_execution_registry_can_build_core_only_registry
    assert set(OPTIONAL_EXECUTION_PROVIDERS) == {'opencode', 'droid'}
E   AssertionError: assert {'agy', 'droid', 'opencode'} == {'droid', 'opencode'}
========== 1 failed, 2239 passed, 21 deselected in 1279.87s ==========

Fix

lib/provider_execution/registry.py:12:

OPTIONAL_EXECUTION_PROVIDERS = OPTIONAL_PROVIDER_NAMES

Pure alias — so the expected set must follow OPTIONAL_PROVIDER_NAMES
literally. Updates the assertion to {'opencode', 'droid', 'agy'} and
adds assert registry.get('agy') is None to maintain coverage
parity with opencode/droid in the include_optional=False path
(since agy has execution_adapter=None in #217 anyway).

My mistake

I tested 12 agy-related test cases locally before opening #217 but
didn't run the full suite, so this test slipped through. PR #211
(the precursor I rebased) also did not catch it because they only ran
the 6 files listed in their PR description.

After this hotfix lands, the recommended verification command
becomes:

uvx --with pyyaml --with tomli pytest \
  test/test_v2_provider_catalog.py \
  test/test_v2_provider_core_registry.py \
  test/test_v2_execution_registry.py \
  test/test_v2_runtime_launch.py -q

Sorry for the breakage @SeemSeam — apologies for not catching this
in #217. 🙏

Hotfix for CI breakage after SeemSeam#217 merged. PR SeemSeam#217 added `agy` to
`OPTIONAL_PROVIDER_NAMES`, but `lib/provider_execution/registry.py`
aliases `OPTIONAL_EXECUTION_PROVIDERS = OPTIONAL_PROVIDER_NAMES`,
so `test_v2_execution_registry.py:13` started failing because the
hardcoded `{'opencode', 'droid'}` set no longer matches the now-
3-element set `{'opencode', 'droid', 'agy'}`.

Fix: update the expected set + add `assert registry.get('agy') is None`
to keep coverage parity with opencode/droid in the core-only registry case.

Verification:
  $ uvx --with pyyaml --with tomli pytest test/test_v2_execution_registry.py -v
  # 1 passed in 0.28s

CI run that broke:
  https://github.com/SeemSeam/claude_codex_bridge/actions/runs/26735236338
@SeemSeam

SeemSeam commented Jun 1, 2026

Copy link
Copy Markdown
Owner

ok I just commit and still not use in the release before test

@SeemSeam SeemSeam merged commit 37a9e12 into SeemSeam:main Jun 1, 2026
14 checks passed
@LeoLin990405 LeoLin990405 deleted the hotfix/agy-execution-registry-test branch June 17, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants