test: include agy in OPTIONAL_EXECUTION_PROVIDERS assertion (hotfix #217 CI break)#218
Merged
SeemSeam merged 1 commit intoJun 1, 2026
Conversation
Hotfix for CI breakage after SeemSeam#217 merged. PR SeemSeam#217 added `agy` to `OPTIONAL_PROVIDER_NAMES`, but `lib/provider_execution/registry.py` aliases `OPTIONAL_EXECUTION_PROVIDERS = OPTIONAL_PROVIDER_NAMES`, so `test_v2_execution_registry.py:13` started failing because the hardcoded `{'opencode', 'droid'}` set no longer matches the now- 3-element set `{'opencode', 'droid', 'agy'}`. Fix: update the expected set + add `assert registry.get('agy') is None` to keep coverage parity with opencode/droid in the core-only registry case. Verification: $ uvx --with pyyaml --with tomli pytest test/test_v2_execution_registry.py -v # 1 passed in 0.28s CI run that broke: https://github.com/SeemSeam/claude_codex_bridge/actions/runs/26735236338
Owner
|
ok I just commit and still not use in the release before test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix for the CI breakage on
mainafter #217 merged. One testexpected the old
OPTIONAL_EXECUTION_PROVIDERSset; #217 addedagyto
OPTIONAL_PROVIDER_NAMES(which the execution registry aliases),so the test needs to be updated.
Broken CI run (8/11 jobs failed, all with the same single
failure):
https://github.com/SeemSeam/claude_codex_bridge/actions/runs/26735236338
Fix
lib/provider_execution/registry.py:12:Pure alias — so the expected set must follow
OPTIONAL_PROVIDER_NAMESliterally. Updates the assertion to
{'opencode', 'droid', 'agy'}andadds
assert registry.get('agy') is Noneto maintain coverageparity with opencode/droid in the
include_optional=Falsepath(since agy has
execution_adapter=Nonein #217 anyway).My mistake
I tested 12 agy-related test cases locally before opening #217 but
didn't run the full suite, so this test slipped through. PR #211
(the precursor I rebased) also did not catch it because they only ran
the 6 files listed in their PR description.
After this hotfix lands, the recommended verification command
becomes:
Sorry for the breakage @SeemSeam — apologies for not catching this
in #217. 🙏