Fix some non-public member names for PSv7 (#7)

Author: SeeminglyScience

src/ImpliedReflection/Commands/AddPrivateMemberCommand.cs

@@ -18,6 +18,18 @@ public class AddPrivateMemberCommand : PSCmdlet
 
         protected override void ProcessRecord()
         {
+            if (PSVersionInfo.PSVersion == PSVersionInfo.Empty)
+            {
+                ThrowTerminatingError(
+                    new ErrorRecord(
+                        new PSInvalidOperationException(ImpliedReflectionStrings.UnknownPowerShellVersion),
+                        nameof(ImpliedReflectionStrings.UnknownPowerShellVersion),
+                        ErrorCategory.InvalidOperation,
+                        targetObject: null));
+
+                return;
+            }
+
             if (InputObject == null)
             {
                 return;

src/ImpliedReflection/Commands/DisableImpliedReflectionCommand.cs

@@ -7,6 +7,18 @@ public class DisableImpliedReflectionCommand : PSCmdlet
     {
         protected override void EndProcessing()
         {
+            if (PSVersionInfo.PSVersion == PSVersionInfo.Empty)
+            {
+                ThrowTerminatingError(
+                    new ErrorRecord(
+                        new PSInvalidOperationException(ImpliedReflectionStrings.UnknownPowerShellVersion),
+                        nameof(ImpliedReflectionStrings.UnknownPowerShellVersion),
+                        ErrorCategory.InvalidOperation,
+                        targetObject: null));
+
+                return;
+            }
+
             if (!DelegateController.Disable())
             {
                 WriteError(

src/ImpliedReflection/Commands/EnableImpliedReflectionCommand.cs

@@ -16,6 +16,18 @@ public class EnableImpliedReflectionCommand : PSCmdlet
 
         protected override void EndProcessing()
         {
+            if (PSVersionInfo.PSVersion == PSVersionInfo.Empty)
+            {
+                ThrowTerminatingError(
+                    new ErrorRecord(
+                        new PSInvalidOperationException(ImpliedReflectionStrings.UnknownPowerShellVersion),
+                        nameof(ImpliedReflectionStrings.UnknownPowerShellVersion),
+                        ErrorCategory.InvalidOperation,
+                        targetObject: null));
+
+                return;
+            }
+
             if (!(Force.IsPresent || ShouldContinue()))
             {
                 return;

src/ImpliedReflection/Core7CLRNames.cs

@@ -0,0 +1,9 @@
+namespace ImpliedReflection
+{
+    internal class Core7CLRNames : CoreCLRNames
+    {
+        public override string PSObject_DotNetInstanceAdapter => "s_dotNetInstanceAdapter";
+
+        public override string PSObject_DotNetStaticAdapter => "s_dotNetStaticAdapter";
+    }
+}

src/ImpliedReflection/PSVersion.cs

@@ -0,0 +1,56 @@
+using System;
+using System.Management.Automation;
+using System.Reflection;
+
+namespace ImpliedReflection
+{
+    /// <summary>
+    /// Represents the real PSVersionInfo class in SMA. Although it recently became public, it
+    /// still isn't in PSv5 which is what we're preferencing, so more reflection.
+    /// </summary>
+    internal static class PSVersionInfo
+    {
+        internal static readonly Version Empty = new Version(0, 0);
+
+        static PSVersionInfo()
+        {
+            Type psVersionInfoType =
+                typeof(PSObject).Assembly.GetType("System.Management.Automation.PSVersionInfo");
+
+            if (psVersionInfoType == null)
+            {
+                PSVersion = Empty;
+                return;
+            }
+
+            PropertyInfo psVersionProperty = psVersionInfoType.GetProperty(
+                nameof(PSVersion),
+                Bind.Any.Static);
+
+            if (psVersionProperty == null || psVersionProperty.PropertyType != typeof(Version))
+            {
+                PSVersion = Empty;
+                return;
+            }
+
+            object version = null;
+            try
+            {
+                version = psVersionProperty.GetValue(null);
+            }
+            catch
+            {
+            }
+
+            if (version == null)
+            {
+                PSVersion = Empty;
+                return;
+            }
+
+            PSVersion = (Version)version;
+        }
+
+        internal static Version PSVersion { get; }
+    }
+}

src/ImpliedReflection/VersionSpecificMemberNames.cs

@@ -1,21 +1,27 @@
-using System.Management.Automation;
-
-namespace ImpliedReflection
+namespace ImpliedReflection
 {
     internal abstract class VersionSpecificMemberNames
     {
         public static VersionSpecificMemberNames PrivateMemberNames;
 
         static VersionSpecificMemberNames()
         {
-            var coreNames = new CoreCLRNames();
-            if (typeof(PSObject).GetField(coreNames.PSObject_memberCollection, Bind.NonPublic.Static) != null)
+            PrivateMemberNames = CreateInstance();
+        }
+
+        private static VersionSpecificMemberNames CreateInstance()
+        {
+            if (PSVersionInfo.PSVersion.Major >= 7)
+            {
+                return new Core7CLRNames();
+            }
+
+            if (PSVersionInfo.PSVersion.Major == 6)
             {
-                PrivateMemberNames = coreNames;
-                return;
+                return new CoreCLRNames();
             }
 
-            PrivateMemberNames = new FullCLRNames();
+            return new FullCLRNames();
         }
 
         /// <summary>

src/ImpliedReflection/resources/ImpliedReflectionStrings.resx

@@ -134,4 +134,7 @@ This can have unintended consequences, are you sure you want to continue?</value
   <data name="ConfirmTitle" xml:space="preserve">
     <value>Confirm</value>
   </data>
+  <data name="UnknownPowerShellVersion" xml:space="preserve">
+    <value>Unable to determine the current PowerShell version. If this is a custom build of PowerShell, please file a GitHub issue for guidance.</value>
+  </data>
 </root>