feat: improve Output.Stop method with timeout handling and return status

Author: Segergren

src/ObsKit.NET/Outputs/Output.cs

@@ -124,19 +124,24 @@ public bool Start()
     /// Stops the output.
     /// </summary>
     /// <param name="waitForCompletion">If true, waits for the output to fully stop.</param>
-    /// <param name="timeoutMs">Maximum time to wait in milliseconds (default 5000).</param>
-    public void Stop(bool waitForCompletion = true, int timeoutMs = 5000)
+    /// <param name="timeoutMs">Maximum time to wait in milliseconds (default 30000).</param>
+    /// <returns>True if the output stopped successfully, false if timed out.</returns>
+    public bool Stop(bool waitForCompletion = true, int timeoutMs = 30000)
     {
+        if (!IsActive) return true;
+
         ObsOutput.obs_output_stop(Handle);
 
         if (waitForCompletion)
         {
-            var startTime = Environment.TickCount;
-            while (IsActive && (Environment.TickCount - startTime) < timeoutMs)
+            var startTime = Environment.TickCount64;
+            while (IsActive && (Environment.TickCount64 - startTime) < timeoutMs)
             {
-                Thread.Sleep(10);
+                Thread.Sleep(50);
             }
         }
+
+        return !IsActive;
     }
 
     /// <summary>

src/ObsKit.NET/Outputs/RecordingOutput.cs

@@ -199,10 +199,8 @@ public RecordingOutput WithNvencEncoders(int videoBitrate = 6000, int audioBitra
     }
 
     /// <summary>Stops the recording.</summary>
-    public void Stop()
-    {
-        base.Stop();
-    }
+    /// <returns>True if the recording stopped successfully, false if timed out.</returns>
+    public bool Stop() => base.Stop();
 
     /// <inheritdoc/>
     protected override void Dispose(bool disposing)

src/ObsKit.NET/Outputs/ReplayBuffer.cs

@@ -197,10 +197,8 @@ public void Save()
     }
 
     /// <summary>Stops the replay buffer.</summary>
-    public void Stop()
-    {
-        base.Stop();
-    }
+    /// <returns>True if the replay buffer stopped successfully, false if timed out.</returns>
+    public bool Stop() => base.Stop();
 
     /// <inheritdoc/>
     protected override void Dispose(bool disposing)