K8s: Template handle scaledJobOptions with value is zero (#3054)

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

Author: VietND96

charts/selenium-grid/templates/_helpers.tpl

@@ -263,7 +263,7 @@ Common autoscaling spec template
 {{- if and $spec (not (empty $spec)) -}}
   {{- $cleanSpec := dict -}}
   {{- range $key, $value := $spec -}}
-    {{- if not (empty $value) -}}
+    {{- if or (kindIs "float64" $value) (kindIs "int64" $value) (kindIs "bool" $value) (not (empty $value)) -}}
       {{- $cleanSpec = set $cleanSpec $key $value -}}
     {{- end -}}
   {{- end -}}

tests/charts/bootstrap.sh

@@ -23,6 +23,12 @@ helm template --debug ${RELEASE_NAME} --values tests/charts/templates/render/dum
   --set-file 'uploaderConfigMap.extraScripts.setFromCommand\.sh=tests/charts/templates/render/dummy_external.sh' \
   tests/tests/selenium-grid-1.0.0-SNAPSHOT.tgz > ./tests/tests/dummy_job_template_manifests.yaml
 
+python3 tests/charts/templates/test_scaled_job.py "./tests/tests/dummy_job_template_manifests.yaml"
+if [ $? -ne 0 ]; then
+  echo "Failed to validate the chart for ScaledJob"
+  exit 1
+fi
+
 helm template --debug ${RELEASE_NAME} --values tests/charts/templates/render/dummy.yaml \
   --set-file 'nodeConfigMap.extraScripts.setFromCommand\.sh=tests/charts/templates/render/dummy_external.sh' \
   --set-file 'recorderConfigMap.extraScripts.setFromCommand\.sh=tests/charts/templates/render/dummy_external.sh' \

tests/charts/templates/render/dummy.yaml

@@ -76,12 +76,12 @@ autoscaling:
       parallelism: 1
       completions: 1
       activeDeadlineSeconds: 600
-      backoffLimit: 6
+      backoffLimit: 0
       template:
     pollingInterval: 30
-    successfulJobsHistoryLimit: 5
+    successfulJobsHistoryLimit: 0
     failedJobsHistoryLimit: 5
-    minReplicaCount: 10
+    minReplicaCount: 0
     maxReplicaCount: 100
     rolloutStrategy: gradual
     rollout:

tests/charts/templates/test_scaled_job.py

@@ -0,0 +1,48 @@
+import logging
+import sys
+import unittest
+
+import yaml
+
+logging.basicConfig(level=logging.INFO, format="%(asctime)s - %(name)s - %(levelname)s - %(message)s")
+logger = logging.getLogger(__name__)
+
+
+def load_template(yaml_file):
+    try:
+        with open(yaml_file) as file:
+            documents = yaml.safe_load_all(file)
+            list_of_documents = [doc for doc in documents]
+            return list_of_documents
+    except yaml.YAMLError as error:
+        print("Error in configuration file: ", error)
+
+
+class ScaledJobTemplateTests(unittest.TestCase):
+    def test_scaled_job_has_zero_limits(self):
+        scaled_jobs = [doc for doc in LIST_OF_DOCUMENTS if doc and doc.get("kind") == "ScaledJob"]
+        self.assertTrue(scaled_jobs, "No ScaledJob resources found")
+        for doc in scaled_jobs:
+            logger.info(f"Assert ScaledJob limits are set to 0 in {doc['metadata']['name']}")
+            self.assertEqual(doc.get("apiVersion"), "keda.sh/v1alpha1")
+            spec = doc.get("spec", {})
+            job_target_ref = spec.get("jobTargetRef", {})
+            self.assertEqual(job_target_ref.get("backoffLimit"), 0)
+            self.assertEqual(spec.get("minReplicaCount"), 0)
+            self.assertEqual(spec.get("successfulJobsHistoryLimit"), 0)
+
+
+if __name__ == "__main__":
+    failed = False
+    try:
+        FILE_NAME = sys.argv[1]
+        LIST_OF_DOCUMENTS = load_template(FILE_NAME)
+        suite = unittest.TestLoader().loadTestsFromTestCase(ScaledJobTemplateTests)
+        test_runner = unittest.TextTestRunner(verbosity=3)
+        failed = not test_runner.run(suite).wasSuccessful()
+    except Exception as e:
+        logger.fatal(e)
+        failed = True
+
+    if failed:
+        exit(1)