Fix recording shutdown for node docker

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

Author: VietND96

StandaloneDocker/Dockerfile

@@ -21,4 +21,6 @@ ENV SE_SESSION_REQUEST_TIMEOUT="300" \
 # Boolean value, maps "--relax-checks"
     SE_RELAX_CHECKS="true" \
     SE_OTEL_SERVICE_NAME="selenium-standalone-docker" \
-    SE_NODE_ENABLE_MANAGED_DOWNLOADS="true"
+    SE_NODE_ENABLE_MANAGED_DOWNLOADS="true" \
+    SE_BIND_BUS="true" \
+    SE_EVENT_BUS_IMPLEMENTATION=""

StandaloneDocker/start-selenium-grid-docker.sh

@@ -108,6 +108,19 @@ if [ ! -z "${SE_EVENT_BUS_HEARTBEAT_PERIOD}" ]; then
   append_se_opts "--eventbus-heartbeat-period" "${SE_EVENT_BUS_HEARTBEAT_PERIOD}"
 fi
 
+if [ ! -z "${SE_EVENT_BUS_IMPLEMENTATION}" ]; then
+  append_se_opts "--events-implementation" "${SE_EVENT_BUS_IMPLEMENTATION}"
+fi
+
+if [ "${SE_BIND_BUS}" = "true" ]; then
+  append_se_opts "--bind-bus" "${SE_BIND_BUS}"
+  append_se_opts "--publish-events" "tcp://*:${SE_EVENT_BUS_PUBLISH_PORT}"
+  append_se_opts "--subscribe-events" "tcp://*:${SE_EVENT_BUS_SUBSCRIBE_PORT}"
+  if [ -z "${SE_EVENT_BUS_IMPLEMENTATION}" ]; then
+    append_se_opts "--events-implementation" "org.openqa.selenium.events.zeromq.ZeroMqEventBus"
+  fi
+fi
+
 if [ "${SE_ENABLE_TLS}" = "true" ]; then
   # Configure truststore for the server
   if [ ! -z "$SE_JAVA_SSL_TRUST_STORE" ]; then

Video/video_recorder.py

@@ -51,6 +51,12 @@ def main():
 
         def _mark_external_shutdown(signum, frame):
             _external_shutdown[0] = True
+            # This handler is only reachable before asyncio.run() installs its
+            # own handlers via loop.add_signal_handler().  Setting the flag and
+            # returning would swallow the signal — nothing would act on it and
+            # the process would hang inside asyncio.run() indefinitely.
+            # Exit immediately so supervisord sees a clean stop.
+            sys.exit(0)
 
         signal.signal(signal.SIGTERM, _mark_external_shutdown)
         signal.signal(signal.SIGINT, _mark_external_shutdown)

tests/docker-compose-v3-test-standalone-docker.yaml

@@ -14,6 +14,7 @@ services:
       - SE_NODE_ENABLE_MANAGED_DOWNLOADS=${SELENIUM_ENABLE_MANAGED_DOWNLOADS}
       - SE_NODE_GRID_URL=${GRID_URL}
       - SE_OPTS=--log-level ${LOG_LEVEL} --enable-managed-downloads ${SELENIUM_ENABLE_MANAGED_DOWNLOADS}
+      - SE_EVENT_BUS_HOST=selenium-hub
       - SE_VIDEO_EVENT_DRIVEN=${VIDEO_EVENT_DRIVEN}
       - SE_VIDEO_RECORD_STANDALONE=${RECORD_STANDALONE}
       - SE_VIDEO_FILE_NAME=${VIDEO_FILE_NAME}