[build] Fix vars context not support in composite action files#3100
Merged
Conversation
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Contributor
Review Summary by QodoFix vars context support in composite action and workflows
WalkthroughsDescription• Replace unsupported vars context in composite action with input parameter • Add authors input to get-latest-upstream composite action • Update all workflow files to pass authors parameter explicitly • Replace hardcoded 'SeleniumHQ' fallback with github.repository_owner Diagramflowchart LR
A["Composite Action<br/>action.yml"] -->|"Add authors input"| B["Input Parameter<br/>authors"]
C["Workflow Files<br/>Multiple YAMLs"] -->|"Pass authors parameter"| A
D["vars Context<br/>Unsupported"] -->|"Replace with"| E["github.repository_owner<br/>Fallback"]
C -->|"Update fallback"| E
File Changes1. .github/actions/get-latest-upstream/action.yml
|
Contributor
Code Review by Qodo
1. Wrong AUTHORS fallback
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| with: | ||
| release: ${{ inputs.release || false }} | ||
| gh_cli_token: ${{ secrets.GITHUB_TOKEN }} | ||
| authors: ${{ vars.AUTHORS || github.repository_owner }} |
Contributor
There was a problem hiding this comment.
1. Wrong authors fallback 🐞 Bug ✓ Correctness
Several workflows now default authors/AUTHORS to github.repository_owner when vars.AUTHORS is unset, which makes fork PR CI query https://api.github.com/repos/<forkOwner>/selenium/... and fail when that repo doesn’t exist. This breaks PR validation because build-test.yml runs on pull_request and calls docker-test.yml, which invokes get-latest-upstream using that fallback.
Agent Prompt
## Issue description
Workflows changed the default upstream Selenium org/user from `SeleniumHQ` to `github.repository_owner` when `vars.AUTHORS` is not set. In fork-based PRs (and any non-SeleniumHQ-owned clones), this causes the `get-latest-upstream` composite action to query a non-existent `${AUTHORS}/selenium` repo and fail.
## Issue Context
- `build-test.yml` runs on `pull_request` and calls reusable workflows like `docker-test.yml`.
- `get-latest-upstream` uses `AUTHORS` to build URLs like `https://api.github.com/repos/${AUTHORS}/selenium/releases`.
- The repo’s Makefile default for `AUTHORS` is `SeleniumHQ`, indicating the intended default upstream.
## Fix
- In all affected workflows, revert fallbacks to `SeleniumHQ` (e.g., `vars.AUTHORS || 'SeleniumHQ'`) instead of `github.repository_owner`.
- Optionally harden the composite action’s env to tolerate an explicitly empty input by using `AUTHORS: ${{ inputs.authors || 'SeleniumHQ' }}`.
## Fix Focus Areas
- .github/workflows/docker-test.yml[210-222]
- .github/workflows/helm-chart-test.yml[180-191]
- .github/workflows/k8s-scaling-test.yml[156-168]
- .github/workflows/nightly.yml[54-73]
- .github/workflows/deploy.yml[82-100]
- .github/workflows/build-ffmpeg.yml[44-49]
- .github/workflows/release-chrome-versions.yml[49-90]
- .github/workflows/release-chrome-for-testing-versions.yml[49-90]
- .github/workflows/release-edge-versions.yml[49-90]
- .github/workflows/release-firefox-versions.yml[49-90]
- .github/actions/get-latest-upstream/action.yml[20-25]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes issue in CI
Motivation and Context
Types of changes
Checklist