[dotnet] Nullable value in dictionary for json preparation (#17087)

Author: nvborisenko

dotnet/src/webdriver/Alert.cs

@@ -78,7 +78,7 @@ public void SendKeys(string keysToSend)
             throw new ArgumentNullException(nameof(keysToSend), "Keys to send must not be null.");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters.Add("text", keysToSend);
 
         this.driver.Execute(DriverCommand.SetAlertValue, parameters);

dotnet/src/webdriver/Chromium/ChromiumDriver.cs

@@ -221,7 +221,7 @@ public ChromiumNetworkConditions NetworkConditions
                 throw new ArgumentNullException(nameof(value), "value must not be null");
             }
 
-            Dictionary<string, object> parameters = new Dictionary<string, object>();
+            Dictionary<string, object?> parameters = new Dictionary<string, object?>();
             parameters["network_conditions"] = value;
 
             this.Execute(SetNetworkConditionsCommand, parameters);
@@ -240,7 +240,7 @@ public void LaunchApp(string id)
             throw new ArgumentNullException(nameof(id), "id must not be null");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters["id"] = id;
 
         this.Execute(LaunchAppCommand, parameters);
@@ -264,9 +264,9 @@ public void SetPermission(string permissionName, string permissionValue)
             throw new ArgumentNullException(nameof(permissionValue), "value must not be null");
         }
 
-        Dictionary<string, object> nameParameter = new Dictionary<string, object>();
+        Dictionary<string, object?> nameParameter = new Dictionary<string, object?>();
         nameParameter["name"] = permissionName;
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters["descriptor"] = nameParameter;
         parameters["state"] = permissionValue;
         this.Execute(SetPermissionCommand, parameters);
@@ -279,14 +279,14 @@ public void SetPermission(string permissionName, string permissionValue)
     /// <param name="commandParameters">Parameters of the command to execute.</param>
     /// <returns>An object representing the result of the command, if applicable.</returns>
     /// <exception cref="ArgumentNullException">If <paramref name="commandName"/> is <see langword="null"/>.</exception>
-    public object? ExecuteCdpCommand(string commandName, Dictionary<string, object> commandParameters)
+    public object? ExecuteCdpCommand(string commandName, Dictionary<string, object?> commandParameters)
     {
         if (commandName == null)
         {
             throw new ArgumentNullException(nameof(commandName), "commandName must not be null");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters["cmd"] = commandName;
         parameters["params"] = commandParameters;
         Response response = this.Execute(ExecuteCdp, parameters);
@@ -404,7 +404,7 @@ public void SelectCastSink(string deviceName)
             throw new ArgumentNullException(nameof(deviceName), "deviceName must not be null");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters["sinkName"] = deviceName;
         this.Execute(SelectCastSinkCommand, parameters);
     }
@@ -420,7 +420,7 @@ public void StartTabMirroring(string deviceName)
             throw new ArgumentNullException(nameof(deviceName), "deviceName must not be null");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters["sinkName"] = deviceName;
         this.Execute(StartCastTabMirroringCommand, parameters);
     }
@@ -436,7 +436,7 @@ public void StartDesktopMirroring(string deviceName)
             throw new ArgumentNullException(nameof(deviceName), "deviceName must not be null");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters["sinkName"] = deviceName;
         this.Execute(StartCastDesktopMirroringCommand, parameters);
     }
@@ -462,7 +462,7 @@ public void StopCasting(string deviceName)
             throw new ArgumentNullException(nameof(deviceName), "deviceName must not be null");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters["sinkName"] = deviceName;
         this.Execute(StopCastingCommand, parameters);
     }

dotnet/src/webdriver/CookieJar.cs

@@ -32,7 +32,7 @@ public ReadOnlyCollection<Cookie> AllCookies
     {
         get
         {
-            Response response = driver.Execute(DriverCommand.GetAllCookies, new Dictionary<string, object>());
+            Response response = driver.Execute(DriverCommand.GetAllCookies, new Dictionary<string, object?>());
 
             List<Cookie> toReturn = new List<Cookie>();
             if (response.Value is object?[] cookies)
@@ -63,7 +63,7 @@ public void AddCookie(Cookie cookie)
             throw new ArgumentNullException(nameof(cookie));
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters.Add("cookie", cookie);
         driver.Execute(DriverCommand.AddCookie, parameters);
     }
@@ -80,7 +80,7 @@ public void DeleteCookieNamed(string name)
             throw new ArgumentException("Cookie name cannot be null or empty", nameof(name));
         }
 
-        Dictionary<string, object> parameters = new() { { "name", name } };
+        Dictionary<string, object?> parameters = new() { { "name", name } };
 
         driver.Execute(DriverCommand.DeleteCookie, parameters);
     }

dotnet/src/webdriver/Firefox/FirefoxDriver.cs

@@ -276,7 +276,7 @@ public FirefoxCommandContext GetContext()
     public void SetContext(FirefoxCommandContext context)
     {
         string contextValue = context.ToString().ToLowerInvariant();
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters["context"] = contextValue;
         this.Execute(SetContextCommand, parameters);
     }
@@ -354,7 +354,7 @@ public string InstallAddOn(string base64EncodedAddOn, bool temporary = false)
             throw new ArgumentNullException(nameof(base64EncodedAddOn), "Base64 encoded add-on must not be null or the empty string");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>()
         {
             ["addon"] = base64EncodedAddOn,
             ["temporary"] = temporary
@@ -376,7 +376,7 @@ public void UninstallAddOn(string addOnId)
             throw new ArgumentNullException(nameof(addOnId), "Base64 encoded add-on must not be null or the empty string");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters["id"] = addOnId;
         this.Execute(UninstallAddOnCommand, parameters);
     }

dotnet/src/webdriver/ICustomDriverCommandExecutor.cs

@@ -34,7 +34,7 @@ public interface ICustomDriverCommandExecutor
     /// <param name="parameters">A <see cref="Dictionary{K, V}"/> containing the names and values of the parameters of the command.</param>
     /// <returns>An object that contains the value returned by the command, if any.</returns>
     /// <exception cref="WebDriverException">The command returned an exceptional value.</exception>
-    object? ExecuteCustomDriverCommand(string driverCommandToExecute, Dictionary<string, object> parameters);
+    object? ExecuteCustomDriverCommand(string driverCommandToExecute, Dictionary<string, object?> parameters);
 
     /// <summary>
     /// Registers a set of commands to be executed with this driver instance.

dotnet/src/webdriver/Logs.cs

@@ -84,7 +84,7 @@ public ReadOnlyCollection<LogEntry> GetLog(string logKind)
 
         List<LogEntry> entries = new List<LogEntry>();
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters.Add("type", logKind);
         Response commandResponse = this.driver.Execute(DriverCommand.GetLog, parameters);
 

dotnet/src/webdriver/Navigator.cs

@@ -106,7 +106,7 @@ public async Task GoToUrlAsync(string url)
             throw new ArgumentNullException(nameof(url), "URL cannot be null.");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>
         {
             { "url", url }
         };

dotnet/src/webdriver/Remote/RemoteWebDriver.cs

@@ -533,7 +533,7 @@ public void DownloadFile(string fileName, string targetDirectory)
             throw new WebDriverException("You must enable downloads in order to work with downloadable files.");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>
         {
             { "name", fileName }
         };

dotnet/src/webdriver/Safari/SafariDriver.cs

@@ -214,7 +214,7 @@ public void SetPermission(string permissionName, bool permissionValue)
 
         Dictionary<string, object> permissions = new Dictionary<string, object>();
         permissions[permissionName] = permissionValue;
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters["permissions"] = permissions;
         this.Execute(SetPermissionsCommand, parameters);
     }

dotnet/src/webdriver/ShadowRoot.cs

@@ -91,7 +91,7 @@ public IWebElement FindElement(By by)
             throw new ArgumentNullException(nameof(by), "by cannot be null");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters.Add("id", this.shadowRootId);
         parameters.Add("using", by.Mechanism);
         parameters.Add("value", by.Criteria);
@@ -115,7 +115,7 @@ public ReadOnlyCollection<IWebElement> FindElements(By by)
             throw new ArgumentNullException(nameof(by), "by cannot be null");
         }
 
-        Dictionary<string, object> parameters = new Dictionary<string, object>();
+        Dictionary<string, object?> parameters = new Dictionary<string, object?>();
         parameters.Add("id", this.shadowRootId);
         parameters.Add("using", by.Mechanism);
         parameters.Add("value", by.Criteria);