Commit 51739f2
authored
fix NPE when response status is null (#17348)
I am not sure in which cases it happens, but I actually saw this error:
```
java.lang.NullPointerException: Cannot invoke "java.lang.Integer.intValue()" because the return value of "org.openqa.selenium.remote.Response.getStatus()" is null
at org.openqa.selenium.remote.ErrorHandler.throwIfResponseFailed(ErrorHandler.java:100)
at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:668)
at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:688)
at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:692)
at org.openqa.selenium.remote.RemoteWebDriver.quit(RemoteWebDriver.java:507)
at com.codeborne.selenide.drivercommands.CloseDriverCommand.quitSafely(CloseDriverCommand.java:50)
at com.codeborne.selenide.drivercommands.CloseDriverCommand.close(CloseDriverCommand.java:35)
at com.codeborne.selenide.impl.WebDriverInstance.dispose(WebDriverInstance.java:61)
at java.base/java.util.concurrent.ConcurrentHashMap$ValuesView.forEach(ConcurrentHashMap.java:4783)
at com.codeborne.selenide.drivercommands.DisposablesRegistry.disposeAllItems(DisposablesRegistry.java:57)
at com.codeborne.selenide.drivercommands.DisposablesRegistry$SelenideCleanupShutdownHook.run(DisposablesRegistry.java:68)
```1 parent e4382d0 commit 51739f2
2 files changed
Lines changed: 14 additions & 2 deletions
File tree
- java
- src/org/openqa/selenium/remote
- test/org/openqa/selenium/remote
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
| |||
97 | 99 | | |
98 | 100 | | |
99 | 101 | | |
| 102 | + | |
100 | 103 | | |
101 | | - | |
| 104 | + | |
102 | 105 | | |
103 | 106 | | |
104 | 107 | | |
| |||
120 | 123 | | |
121 | 124 | | |
122 | 125 | | |
123 | | - | |
| 126 | + | |
124 | 127 | | |
125 | 128 | | |
126 | 129 | | |
| |||
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
107 | 116 | | |
108 | 117 | | |
109 | 118 | | |
| |||
0 commit comments