Skip to content

Commit 73019cd

Browse files
authored
[rust] Reuse constant for --version
1 parent 4a530c5 commit 73019cd

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

rust/src/lib.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -659,8 +659,10 @@ pub trait SeleniumManager {
659659
}
660660

661661
fn find_driver_in_path(&self) -> (Option<String>, Option<String>) {
662-
let driver_version_command =
663-
Command::new(self.get_driver_name(), vec![String::from("--version")]);
662+
let driver_version_command = Command::new(
663+
self.get_driver_name(),
664+
vec![String::from(DASH_DASH_VERSION)],
665+
);
664666
match run_shell_command(driver_version_command) {
665667
Ok(output) => {
666668
let parsed_version = parse_version(output, self.get_logger()).unwrap_or_default();

rust/tests/common.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
use assert_cmd::Command;
1919
use assert_cmd::assert::AssertResult;
2020
use is_executable::is_executable;
21+
use selenium_manager::DASH_DASH_VERSION;
2122
use selenium_manager::files::path_to_string;
2223
use selenium_manager::logger::JsonOutput;
2324
use selenium_manager::shell;
@@ -81,7 +82,8 @@ pub fn get_driver_path(cmd: &mut Command) -> String {
8182
pub fn exec_driver(cmd: &mut Command) -> String {
8283
let cmd_mut = cmd.borrow_mut();
8384
let driver_path = get_driver_path(cmd_mut);
84-
let driver_version_command = shell::Command::new(&driver_path, vec![String::from("--version")]);
85+
let driver_version_command =
86+
shell::Command::new(&driver_path, vec![String::from(DASH_DASH_VERSION)]);
8587
let output = run_shell_command(driver_version_command).unwrap();
8688
println!("**** EXEC DRIVER: {}", output);
8789
output

0 commit comments

Comments
 (0)