[dotnet] [bidi] Fully immutable commands and events (#17077)

Author: nvborisenko

dotnet/src/webdriver/BiDi/Browser/CloseCommand.cs

@@ -22,6 +22,6 @@ namespace OpenQA.Selenium.BiDi.Browser;
 internal sealed class CloseCommand()
     : Command<Parameters, CloseResult>(Parameters.Empty, "browser.close");
 
-public sealed class CloseOptions : CommandOptions;
+public sealed record CloseOptions : CommandOptions;
 
 public sealed record CloseResult : EmptyResult;

dotnet/src/webdriver/BiDi/Browser/CreateUserContextCommand.cs

@@ -24,13 +24,13 @@ internal sealed class CreateUserContextCommand(CreateUserContextParameters @para
 
 internal sealed record CreateUserContextParameters(bool? AcceptInsecureCerts, Session.ProxyConfiguration? Proxy, Session.UserPromptHandler? UnhandledPromptBehavior) : Parameters;
 
-public sealed class CreateUserContextOptions : CommandOptions
+public sealed record CreateUserContextOptions : CommandOptions
 {
-    public bool? AcceptInsecureCerts { get; set; }
+    public bool? AcceptInsecureCerts { get; init; }
 
-    public Session.ProxyConfiguration? Proxy { get; set; }
+    public Session.ProxyConfiguration? Proxy { get; init; }
 
-    public Session.UserPromptHandler? UnhandledPromptBehavior { get; set; }
+    public Session.UserPromptHandler? UnhandledPromptBehavior { get; init; }
 }
 
 public sealed record CreateUserContextResult(UserContext UserContext) : UserContextInfo(UserContext);

dotnet/src/webdriver/BiDi/Browser/GetClientWindowsCommand.cs

@@ -24,6 +24,6 @@ namespace OpenQA.Selenium.BiDi.Browser;
 internal sealed class GetClientWindowsCommand()
     : Command<Parameters, GetClientWindowsResult>(Parameters.Empty, "browser.getClientWindows");
 
-public sealed class GetClientWindowsOptions : CommandOptions;
+public sealed record GetClientWindowsOptions : CommandOptions;
 
 public sealed record GetClientWindowsResult(IReadOnlyList<ClientWindowInfo> ClientWindows) : EmptyResult;

dotnet/src/webdriver/BiDi/Browser/GetUserContextsCommand.cs

@@ -24,6 +24,6 @@ namespace OpenQA.Selenium.BiDi.Browser;
 internal sealed class GetUserContextsCommand()
     : Command<Parameters, GetUserContextsResult>(Parameters.Empty, "browser.getUserContexts");
 
-public class GetUserContextsOptions : CommandOptions;
+public record GetUserContextsOptions : CommandOptions;
 
 public sealed record GetUserContextsResult(IReadOnlyList<UserContextInfo> UserContexts) : EmptyResult;

dotnet/src/webdriver/BiDi/Browser/RemoveUserContextCommand.cs

@@ -24,6 +24,6 @@ internal sealed class RemoveUserContextCommand(RemoveUserContextParameters @para
 
 internal sealed record RemoveUserContextParameters(UserContext UserContext) : Parameters;
 
-public sealed class RemoveUserContextOptions : CommandOptions;
+public sealed record RemoveUserContextOptions : CommandOptions;
 
 public sealed record RemoveUserContextResult : EmptyResult;

dotnet/src/webdriver/BiDi/Browser/SetDownloadBehaviorCommand.cs

@@ -36,9 +36,9 @@ internal sealed record DownloadBehaviorAllowed(string DestinationFolder) : Downl
 
 internal sealed record DownloadBehaviorDenied : DownloadBehavior;
 
-public sealed class SetDownloadBehaviorOptions : CommandOptions
+public sealed record SetDownloadBehaviorOptions : CommandOptions
 {
-    public IEnumerable<UserContext>? UserContexts { get; set; }
+    public IEnumerable<UserContext>? UserContexts { get; init; }
 }
 
 public sealed record SetDownloadBehaviorResult : EmptyResult;

dotnet/src/webdriver/BiDi/BrowsingContext/ActivateCommand.cs

@@ -24,6 +24,6 @@ internal sealed class ActivateCommand(ActivateParameters @params)
 
 internal sealed record ActivateParameters(BrowsingContext Context) : Parameters;
 
-public sealed class ActivateOptions : CommandOptions;
+public sealed record ActivateOptions : CommandOptions;
 
 public sealed record ActivateResult : EmptyResult;

dotnet/src/webdriver/BiDi/BrowsingContext/BrowsingContextNetworkModule.cs

@@ -272,8 +272,8 @@ private void HandleAuthRequired(AuthRequiredEventArgs e, Action<AuthRequiredEven
     }
 }
 
-public sealed class InterceptRequestOptions : ContextAddInterceptOptions;
+public sealed record InterceptRequestOptions : ContextAddInterceptOptions;
 
-public sealed class InterceptResponseOptions : ContextAddInterceptOptions;
+public sealed record InterceptResponseOptions : ContextAddInterceptOptions;
 
-public sealed class InterceptAuthOptions : ContextAddInterceptOptions;
+public sealed record InterceptAuthOptions : ContextAddInterceptOptions;

dotnet/src/webdriver/BiDi/BrowsingContext/BrowsingContextScriptModule.cs

@@ -38,12 +38,10 @@ public Task<GetRealmsResult> GetRealmsAsync(ContextGetRealmsOptions? options = n
 
     public Task<EvaluateResult> EvaluateAsync([StringSyntax(StringSyntaxConstants.JavaScript)] string expression, bool awaitPromise, EvaluateOptions? options = null, ContextTargetOptions? targetOptions = null, CancellationToken cancellationToken = default)
     {
-        var contextTarget = new ContextTarget(context);
-
-        if (targetOptions is not null)
+        var contextTarget = new ContextTarget(context)
         {
-            contextTarget.Sandbox = targetOptions.Sandbox;
-        }
+            Sandbox = targetOptions?.Sandbox
+        };
 
         return scriptModule.EvaluateAsync(expression, awaitPromise, contextTarget, options, cancellationToken);
     }
@@ -57,12 +55,10 @@ public Task<EvaluateResult> EvaluateAsync([StringSyntax(StringSyntaxConstants.Ja
 
     public Task<EvaluateResult> CallFunctionAsync([StringSyntax(StringSyntaxConstants.JavaScript)] string functionDeclaration, bool awaitPromise, CallFunctionOptions? options = null, ContextTargetOptions? targetOptions = null, CancellationToken cancellationToken = default)
     {
-        var contextTarget = new ContextTarget(context);
-
-        if (targetOptions is not null)
+        var contextTarget = new ContextTarget(context)
         {
-            contextTarget.Sandbox = targetOptions.Sandbox;
-        }
+            Sandbox = targetOptions?.Sandbox
+        };
 
         return scriptModule.CallFunctionAsync(functionDeclaration, awaitPromise, contextTarget, options, cancellationToken);
     }

dotnet/src/webdriver/BiDi/BrowsingContext/CaptureScreenshotCommand.cs

@@ -28,13 +28,13 @@ internal sealed class CaptureScreenshotCommand(CaptureScreenshotParameters @para
 
 internal sealed record CaptureScreenshotParameters(BrowsingContext Context, ScreenshotOrigin? Origin, ImageFormat? Format, ClipRectangle? Clip) : Parameters;
 
-public sealed class CaptureScreenshotOptions : CommandOptions
+public sealed record CaptureScreenshotOptions : CommandOptions
 {
-    public ScreenshotOrigin? Origin { get; set; }
+    public ScreenshotOrigin? Origin { get; init; }
 
-    public ImageFormat? Format { get; set; }
+    public ImageFormat? Format { get; init; }
 
-    public ClipRectangle? Clip { get; set; }
+    public ClipRectangle? Clip { get; init; }
 }
 
 [JsonConverter(typeof(CamelCaseEnumConverter<ScreenshotOrigin>))]
@@ -46,7 +46,7 @@ public enum ScreenshotOrigin
 
 public record struct ImageFormat(string Type)
 {
-    public double? Quality { get; set; }
+    public double? Quality { get; init; }
 }
 
 [JsonPolymorphic(TypeDiscriminatorPropertyName = "type")]