[build] use pinned browser and driver for starting grid in python and ruby tests (#17610)

* [py][rb] Use pinned browser and driver for remote Grid tests instead of Selenium Manager

* [java] Fix --driver-configuration CLI example to use webdriver-executable

* [py] guard selenium manager  test from running on rbe

Author: titusfortner

.bazelrc.remote

@@ -41,6 +41,9 @@ build:rbe --action_env=PATH=/bin:/usr/bin:/usr/local/bin
 test:rbe --test_env=PATH=/bin:/usr/bin:/usr/local/bin
 test:rbe --test_env=HOME=/home/dev
 
+# This should only be set on GitHub runs
+test:rbe --test_env=SE_CACHE_PATH=
+
 # Make sure we sniff credentials properly
 build:rbe --credential_helper=gypsum.cluster.engflow.com=%workspace%/scripts/credential-helper.sh
 

java/src/org/openqa/selenium/grid/node/config/NodeFlags.java

@@ -161,7 +161,7 @@ public class NodeFlags implements HasRoles {
               + "It is recommended to provide this type of configuration through a toml config "
               + "file to improve readability. Command line example: "
               + "--driver-configuration display-name=\"Firefox Nightly\" max-sessions=2 "
-              + "webdriver-path=\"/usr/local/bin/geckodriver\" "
+              + "webdriver-executable=\"/usr/local/bin/geckodriver\" "
               + "stereotype=\"{\\\"browserName\\\": \\\"firefox\\\", "
               + "\\\"browserVersion\\\": \\\"86\\\", "
               + "\\\"moz:firefoxOptions\\\": "

py/conftest.py

@@ -16,6 +16,7 @@
 # under the License.
 
 import http.server
+import json
 import os
 import socketserver
 import sys
@@ -208,6 +209,43 @@ def _resolve_bazel_path(path):
     return path
 
 
+# Maps the test driver name to its (browserName, vendor options key).
+_GRID_VENDOR_OPTIONS = {
+    "chrome": ("chrome", "goog:chromeOptions"),
+    "edge": ("MicrosoftEdge", "ms:edgeOptions"),
+    "firefox": ("firefox", "moz:firefoxOptions"),
+}
+
+
+def _pinned_grid_args(config):
+    """Pin the driver and browser in a driver-configuration so the Grid node skips Selenium Manager.
+
+    Returns an empty list when nothing is pinned, keeping the default Selenium Manager behavior.
+    """
+    drivers_opt = config.option.drivers or []
+    driver = next((d for d in drivers_opt if d.lower() in _GRID_VENDOR_OPTIONS), None)
+    executable = config.option.executable  # --driver-binary
+    binary = config.option.binary  # --browser-binary
+    if not (driver and executable and binary):
+        return []
+
+    driver_path = _resolve_bazel_path(executable).strip("'")
+    browser_path = _resolve_bazel_path(binary).strip("'")
+    browser_name, vendor_key = _GRID_VENDOR_OPTIONS[driver.lower()]
+    stereotype = json.dumps({"browserName": browser_name, vendor_key: {"binary": browser_path}})
+    return [
+        "--enable-managed-downloads",
+        "true",
+        "--detect-drivers",
+        "false",
+        "--driver-configuration",
+        f"display-name={driver}",
+        "max-sessions=1",
+        f"webdriver-executable={driver_path}",
+        f"stereotype={stereotype}",
+    ]
+
+
 def get_extensions_location():
     """Locate the test extensions directory.
 
@@ -551,7 +589,7 @@ def server(request):
         # under Wayland, so we use XWayland instead.
         remote_env["MOZ_ENABLE_WAYLAND"] = "0"
 
-    server = Server(env=remote_env, startup_timeout=60)
+    server = Server(env=remote_env, startup_timeout=60, args=_pinned_grid_args(request.config) or None)
 
     repo_root = Path(__file__).parent.parent  # py/conftest.py -> py/ -> selenium/
     jar_path = "java/src/org/openqa/selenium/grid/selenium_server_deploy.jar"

py/selenium/webdriver/remote/server.py

@@ -44,8 +44,13 @@ class Server:
             Available levels: "SEVERE", "WARNING", "INFO", "CONFIG", "FINE", "FINER", "FINEST".
         env: Mapping that defines the environment variables for the server process.
         java_path: Path to the java executable to run the server.
+        args: Arguments for the standalone server command. Defaults to enabling Selenium
+            Manager and managed downloads; pass a list to override these entirely (e.g. to
+            pin drivers with "--driver-configuration").
     """
 
+    DEFAULT_ARGS = ("--selenium-manager", "true", "--enable-managed-downloads", "true")
+
     def __init__(
         self,
         host=None,
@@ -56,6 +61,7 @@ def __init__(
         env=None,
         java_path=None,
         startup_timeout=10,
+        args=None,
     ):
         if path and version:
             raise TypeError("Not allowed to specify a version when using an existing server path")
@@ -68,6 +74,7 @@ def __init__(
         self.env = env
         self.java_path = java_path
         self.startup_timeout = startup_timeout
+        self.args = list(args) if args is not None else list(self.DEFAULT_ARGS)
         self.process = None
 
     @property
@@ -190,10 +197,7 @@ def start(self):
             str(self.port),
             "--log-level",
             self.log_level,
-            "--selenium-manager",
-            "true",
-            "--enable-managed-downloads",
-            "true",
+            *self.args,
         ]
         if self.host is not None:
             command.extend(["--host", self.host])

py/test/selenium/webdriver/remote/remote_server_tests.py

@@ -38,6 +38,10 @@ def remove_file(path):
         pass
 
 
+@pytest.mark.skipif(
+    "REMOTE_BUILD" in os.environ,
+    reason="Downloads the Selenium Server from the network, which is unavailable on RBE",
+)
 def test_download_latest_server(standalone_server):
     server_path = standalone_server.download_if_needed()
     assert os.path.exists(server_path)

py/test/unit/selenium/webdriver/remote/remote_server_tests.py

@@ -49,6 +49,18 @@ def test_server_with_kwargs():
     assert server.env == {"FOO": "bar"}
 
 
+def test_server_with_default_args():
+    server = Server()
+    assert server.args == list(Server.DEFAULT_ARGS)
+
+
+def test_server_with_args_override():
+    args = ["--detect-drivers", "false", "--driver-configuration", "display-name=chrome"]
+    server = Server(args=args)
+    assert server.args == args
+    assert server.args is not args
+
+
 def test_server_with_invalid_port():
     port = "invalid"
     msg = f"Server.__init__() got an invalid port: '{port}'"

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

@@ -98,17 +98,9 @@ def app_server
         end
 
         def remote_server
-          args = if ENV.key?('CHROMEDRIVER_BINARY')
-                   ["-Dwebdriver.chrome.driver=#{rlocation(ENV['CHROMEDRIVER_BINARY'])}"]
-                 elsif ENV.key?('MSEDGEDRIVER_BINARY')
-                   ["-Dwebdriver.edge.driver=#{rlocation(ENV['MSEDGEDRIVER_BINARY'])}"]
-                 elsif ENV.key?('GECKODRIVER_BINARY')
-                   ["-Dwebdriver.gecko.driver=#{rlocation(ENV['GECKODRIVER_BINARY'])}"]
-                 else
-                   %w[--selenium-manager true]
-                 end
+          args = driver_path ? %w[--detect-drivers false] : %w[--selenium-manager true]
           args += %w[--enable-managed-downloads true]
-          args += version_stereotype_args unless browser_version == 'stable'
+          args += driver_configuration if driver_path || browser_version != 'stable'
 
           @remote_server ||= Selenium::Server.new(
             remote_server_jar,
@@ -121,12 +113,31 @@ def remote_server
           )
         end
 
-        def version_stereotype_args
-          stereotype = {browserName: w3c_browser_name, browserVersion: browser_version}.to_json
-          ['--driver-configuration',
-           "display-name=#{browser} #{browser_version}",
-           'max-sessions=5',
-           "stereotype=#{stereotype}"]
+        def driver_configuration
+          stereotype = {browserName: w3c_browser_name}
+          stereotype[:browserVersion] = browser_version unless browser_version == 'stable'
+          stereotype[options_key] = {binary: browser_path} if browser_path
+
+          config = ['--driver-configuration',
+                    "display-name=#{browser} #{browser_version}",
+                    'max-sessions=5']
+          config << "webdriver-executable=#{driver_path}" if driver_path
+          config << "stereotype=#{stereotype.to_json}"
+          config
+        end
+
+        def driver_path
+          env = {chrome: 'CHROMEDRIVER_BINARY', edge: 'MSEDGEDRIVER_BINARY', firefox: 'GECKODRIVER_BINARY'}[browser]
+          rlocation(ENV.fetch(env)) if env && ENV.key?(env)
+        end
+
+        def browser_path
+          env = "#{browser.to_s.upcase}_BINARY"
+          rlocation(ENV.fetch(env)) if ENV.key?(env)
+        end
+
+        def options_key
+          {chrome: 'goog:chromeOptions', edge: 'ms:edgeOptions', firefox: 'moz:firefoxOptions'}[browser]
         end
 
         def w3c_browser_name

rust/tests/cache_tests.rs

@@ -29,6 +29,7 @@ mod common;
 #[case("../テスト")]
 fn cache_path_test(#[case] tmp_cache_folder_name: String) {
     let mut cmd = get_selenium_manager();
+    cmd.env_remove("SE_CACHE_PATH");
     cmd.args([
         "--browser",
         "chrome",

rust/tests/config_tests.rs

@@ -40,6 +40,7 @@ fn config_test(#[case] browser_name: String) {
     writer.flush().unwrap();
 
     let mut cmd = get_selenium_manager();
+    cmd.env_remove("SE_CACHE_PATH");
     cmd.args([
         "--output",
         "json",