address failures

Author: titusfortner

.bazelrc.remote

@@ -41,6 +41,9 @@ build:rbe --action_env=PATH=/bin:/usr/bin:/usr/local/bin
 test:rbe --test_env=PATH=/bin:/usr/bin:/usr/local/bin
 test:rbe --test_env=HOME=/home/dev
 
+# This should only be set on GitHub runs
+test:rbe --test_env=SE_CACHE_PATH=
+
 # Make sure we sniff credentials properly
 build:rbe --credential_helper=gypsum.cluster.engflow.com=%workspace%/scripts/credential-helper.sh
 

py/test/unit/selenium/webdriver/remote/remote_server_tests.py

@@ -49,6 +49,18 @@ def test_server_with_kwargs():
     assert server.env == {"FOO": "bar"}
 
 
+def test_server_with_default_args():
+    server = Server()
+    assert server.args == list(Server.DEFAULT_ARGS)
+
+
+def test_server_with_args_override():
+    args = ["--detect-drivers", "false", "--driver-configuration", "display-name=chrome"]
+    server = Server(args=args)
+    assert server.args == args
+    assert server.args is not args
+
+
 def test_server_with_invalid_port():
     port = "invalid"
     msg = f"Server.__init__() got an invalid port: '{port}'"

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

@@ -116,7 +116,7 @@ def remote_server
         def driver_configuration
           stereotype = {browserName: w3c_browser_name}
           stereotype[:browserVersion] = browser_version unless browser_version == 'stable'
-          stereotype[options_key] = {binary: browser_path} if driver_path
+          stereotype[options_key] = {binary: browser_path} if browser_path
 
           config = ['--driver-configuration',
                     "display-name=#{browser} #{browser_version}",

rust/tests/cache_tests.rs

@@ -29,6 +29,7 @@ mod common;
 #[case("../テスト")]
 fn cache_path_test(#[case] tmp_cache_folder_name: String) {
     let mut cmd = get_selenium_manager();
+    cmd.env_remove("SE_CACHE_PATH");
     cmd.args([
         "--browser",
         "chrome",

rust/tests/config_tests.rs

@@ -40,6 +40,7 @@ fn config_test(#[case] browser_name: String) {
     writer.flush().unwrap();
 
     let mut cmd = get_selenium_manager();
+    cmd.env_remove("SE_CACHE_PATH");
     cmd.args([
         "--output",
         "json",