Skip to content

Commit c4d177e

Browse files
committed
split up tests
1 parent 72dbe5d commit c4d177e

3 files changed

Lines changed: 40 additions & 6 deletions

File tree

.github/workflows/ci-javascript.yml

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,30 @@ on:
77
required: false
88
type: string
99
default: ''
10+
run-full-suite:
11+
required: false
12+
type: boolean
13+
default: true
1014
workflow_dispatch:
1115

1216
permissions:
1317
contents: read
1418

1519
jobs:
20+
unit-tests:
21+
name: Unit Tests
22+
if: ${{ inputs.run-full-suite }}
23+
uses: ./.github/workflows/bazel.yml
24+
with:
25+
name: Unit Tests
26+
os: ubuntu
27+
run: >
28+
bazel test
29+
--keep_going
30+
--build_tests_only
31+
--test_size_filters=small
32+
${{ needs.filter-targets.outputs.targets }}
33+
1634
filter-targets:
1735
name: Filter Targets
1836
runs-on: ubuntu-latest
@@ -40,17 +58,23 @@ jobs:
4058
name: Browser Tests
4159
needs: filter-targets
4260
uses: ./.github/workflows/bazel.yml
61+
strategy:
62+
fail-fast: false
63+
matrix:
64+
browser: [chrome, firefox, chrome-bidi, firefox-bidi]
65+
os: [windows]
4366
with:
44-
name: Browser Tests
45-
os: windows
46-
browser: true
67+
name: Browser Tests (${{ matrix.browser }}, ${{ matrix.os }})
68+
os: ${{ matrix.os }}
69+
browser: ${{ matrix.browser }}
4770
run: >
4871
bazel test
4972
--keep_going
5073
--build_tests_only
5174
--flaky_test_attempts 3
5275
--local_test_jobs 1
53-
--test_tag_filters=-lint
76+
--test_size_filters=large
77+
--test_tag_filters=${{ matrix.browser }}
5478
--pin_browsers=false
5579
--test_env=SE_FORCE_BROWSER_DOWNLOAD=true
5680
--test_env=SE_SKIP_DRIVER_IN_PATH=true

.github/workflows/ci.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,13 @@ jobs:
116116
uses: ./.github/workflows/ci-javascript.yml
117117
with:
118118
targets: ${{ needs.check.outputs.targets }}
119+
run-full-suite: >-
120+
${{
121+
github.event_name == 'schedule' ||
122+
github.event_name == 'workflow_dispatch' ||
123+
github.event_name == 'workflow_call' ||
124+
contains(github.event.pull_request.title, '[js]')
125+
}}
119126
if: >
120127
github.event_name == 'schedule' ||
121128
github.event_name == 'workflow_dispatch' ||

javascript/selenium-webdriver/BUILD.bazel

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,11 @@ mocha_test(
202202
env = {
203203
"SELENIUM_BROWSER": browser,
204204
} | BROWSERS[browser]["env"],
205-
tags = [
206-
browser,
205+
tags = (
206+
["%s-bidi" % browser]
207+
if test.startswith("test/bidi/")
208+
else [browser]
209+
) + [
207210
"browser-test",
208211
"no-sandbox",
209212
"requires-network",

0 commit comments

Comments
 (0)