Skip to content

Commit d5f22ec

Browse files
committed
[java] mark tests passing in latest chrome beta
1 parent 89c5993 commit d5f22ec

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

java/test/org/openqa/selenium/bidi/emulation/SetScreenSettingsOverrideTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
package org.openqa.selenium.bidi.emulation;
1919

2020
import static org.assertj.core.api.Assertions.assertThat;
21+
import static org.assertj.core.api.Assumptions.assumeThat;
2122
import static org.openqa.selenium.testing.drivers.Browser.CHROME;
2223
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
2324

@@ -33,6 +34,7 @@
3334
import org.openqa.selenium.testing.JupiterTestBase;
3435
import org.openqa.selenium.testing.NeedsFreshDriver;
3536
import org.openqa.selenium.testing.NotYetImplemented;
37+
import org.openqa.selenium.testing.TestUtilities;
3638

3739
class SetScreenSettingsOverrideTest extends JupiterTestBase {
3840
private Dimension getScreenDimensions(String context) {
@@ -46,9 +48,12 @@ private Dimension getScreenDimensions(String context) {
4648

4749
@Test
4850
@NeedsFreshDriver
49-
@NotYetImplemented(CHROME)
5051
@NotYetImplemented(EDGE)
5152
void canSetScreenSettingsOverrideInContext() {
53+
if (org.openqa.selenium.testing.drivers.Browser.detect() == CHROME) {
54+
assumeThat(TestUtilities.getChromeVersion(driver)).isGreaterThanOrEqualTo(146);
55+
}
56+
5257
BrowsingContext context = new BrowsingContext(driver, driver.getWindowHandle());
5358
String contextId = context.getId();
5459

@@ -77,9 +82,12 @@ void canSetScreenSettingsOverrideInContext() {
7782

7883
@Test
7984
@NeedsFreshDriver
80-
@NotYetImplemented(CHROME)
8185
@NotYetImplemented(EDGE)
8286
void canSetScreenSettingsOverrideInUserContext() {
87+
if (org.openqa.selenium.testing.drivers.Browser.detect() == CHROME) {
88+
assumeThat(TestUtilities.getChromeVersion(driver)).isGreaterThanOrEqualTo(146);
89+
}
90+
8391
Browser browser = new Browser(driver);
8492
String initialWindow = driver.getWindowHandle();
8593
String userContext = browser.createUserContext();

0 commit comments

Comments
 (0)