[py] Extract feature-specific modules from //py:common (#17606)

* [py] Extract feature-specific modules from //py:common (P2b/P2d)

Modules that are only used by a small subset of tests were still bundled
in //py:common, causing those modules to be compiled into every test's
transitive dep graph. Changing any of them triggered a full rebuild of
all ~700 browser test targets.

This change extracts five modules into dedicated libraries:
  - //py:common_fedcm        (fedcm/**/*.py)
  - //py:common_timeouts     (timeouts.py)
  - //py:common_virtual_authenticator (virtual_authenticator.py)
  - //py:common_api_request_context   (api_request_context.py)
  - //py:common_print_page_options    (print_page_options.py)

For each module, the corresponding browser test file (e.g. timeout_tests.py,
virtual_authenticator_tests.py) is the only test that imports it directly.
New per-feature test sub-suites (test-chrome-timeouts, test-chrome-fedcm,
etc.) carry the right //py:common_* dep; the -common suites have no dep
on these libraries. Aggregate test_suite targets (test-chrome, test-chrome-bidi,
test-chrome-remote, etc.) are unchanged so CI targets are unaffected.

For the split to be precise, remote/webdriver.py previously imported these
modules at the top level, which would have re-added them to every test's
dep graph via //py:remote. Three changes remove this:
  - from __future__ import annotations makes all type annotations lazy
    strings, so no runtime import is needed for parameter/return types.
  - The four methods that instantiate these types (timeouts property,
    request property, dialog property, get_credentials) now lazy-import
    inside the method body.
  - The required_virtual_authenticator and required_chromium_based_browser
    decorators are inlined in remote/webdriver.py (they were only used
    there; the 10-line definition removes the top-level dep).

Result: changing timeouts.py now only rebuilds ~11 test targets
(timeout_tests × browser variants) instead of ~700.

Author: AutomatedTester

py/BUILD.bazel

@@ -296,8 +296,13 @@ py_library(
         exclude = [
             "selenium/webdriver/common/action_chains.py",
             "selenium/webdriver/common/actions/**",
+            "selenium/webdriver/common/api_request_context.py",
             "selenium/webdriver/common/bidi/**",
             "selenium/webdriver/common/devtools/**",
+            "selenium/webdriver/common/fedcm/**",
+            "selenium/webdriver/common/print_page_options.py",
+            "selenium/webdriver/common/timeouts.py",
+            "selenium/webdriver/common/virtual_authenticator.py",
         ],
     ),
     data = [
@@ -331,6 +336,46 @@ py_library(
     ],
 )
 
+py_library(
+    name = "common_api_request_context",
+    srcs = ["selenium/webdriver/common/api_request_context.py"],
+    imports = ["."],
+    visibility = ["//visibility:public"],
+    deps = [":exceptions"],
+)
+
+py_library(
+    name = "common_fedcm",
+    srcs = glob(["selenium/webdriver/common/fedcm/**/*.py"]),
+    imports = ["."],
+    visibility = ["//visibility:public"],
+    deps = [":exceptions"],
+)
+
+py_library(
+    name = "common_print_page_options",
+    srcs = ["selenium/webdriver/common/print_page_options.py"],
+    imports = ["."],
+    visibility = ["//visibility:public"],
+    deps = [],
+)
+
+py_library(
+    name = "common_timeouts",
+    srcs = ["selenium/webdriver/common/timeouts.py"],
+    imports = ["."],
+    visibility = ["//visibility:public"],
+    deps = [],
+)
+
+py_library(
+    name = "common_virtual_authenticator",
+    srcs = ["selenium/webdriver/common/virtual_authenticator.py"],
+    imports = ["."],
+    visibility = ["//visibility:public"],
+    deps = [":exceptions"],
+)
+
 # Module that points to the latest devtools module
 py_library(
     name = "latest",
@@ -468,6 +513,11 @@ py_library(
         ":chromium",
         ":common",
         ":common_actions",
+        ":common_api_request_context",
+        ":common_fedcm",
+        ":common_print_page_options",
+        ":common_timeouts",
+        ":common_virtual_authenticator",
         ":edge",
         ":exceptions",
         ":firefox",
@@ -701,6 +751,19 @@ py_library(
 
 BIDI_TESTS = glob(["test/selenium/webdriver/common/**/*bidi*_tests.py"])
 
+# Test files that only run against browsers supporting the given feature.
+# Each group is split into its own sub-suite so that changing the underlying
+# library only triggers that group's targets, not the full ~700-target suite.
+FEDCM_TESTS = ["test/selenium/webdriver/common/fedcm_tests.py"]
+
+TIMEOUTS_TESTS = ["test/selenium/webdriver/common/timeout_tests.py"]
+
+VIRTUAL_AUTH_TESTS = ["test/selenium/webdriver/common/virtual_authenticator_tests.py"]
+
+API_REQUEST_TESTS = ["test/selenium/webdriver/common/api_request_context_tests.py"]
+
+FEATURE_TESTS = FEDCM_TESTS + TIMEOUTS_TESTS + VIRTUAL_AUTH_TESTS + API_REQUEST_TESTS
+
 # Test files that import from selenium.webdriver.common.actions / action_chains.
 # These are kept separate so they can depend on :common_actions without pulling
 # that library into every other test suite.
@@ -798,7 +861,7 @@ DEFAULT_BROWSER_TESTS = [b for b in BROWSER_TESTS if b != "ie"]
                 "test/selenium/webdriver/common/**/*.py",
                 "test/selenium/webdriver/support/**/*.py",
             ] + BROWSER_TESTS[browser]["browser_srcs"],
-            exclude = BIDI_TESTS + ACTIONS_TESTS + ["test/selenium/webdriver/common/print_pdf_tests.py"] +
+            exclude = BIDI_TESTS + ACTIONS_TESTS + FEATURE_TESTS + ["test/selenium/webdriver/common/print_pdf_tests.py"] +
                       BROWSER_TESTS[browser].get("extra_excludes", []),
         ),
         args = [
@@ -839,13 +902,45 @@ DEFAULT_BROWSER_TESTS = [b for b in BROWSER_TESTS if b != "ie"]
     for browser in DEFAULT_BROWSER_TESTS
 ]
 
-# Aggregate test-<browser> = common + actions (keeps CI targets unchanged)
+# Feature test definitions: suffix -> (srcs, dep)
+FEATURE_SUITE_DEFS = {
+    "fedcm": (FEDCM_TESTS, ":common_fedcm"),
+    "timeouts": (TIMEOUTS_TESTS, ":common_timeouts"),
+    "virtual-auth": (VIRTUAL_AUTH_TESTS, ":common_virtual_authenticator"),
+    "api-request": (API_REQUEST_TESTS, ":common_api_request_context"),
+}
+
+# Generate test-<browser>-<feature> targets (non-bidi, one per feature library)
+[
+    py_test_suite(
+        name = "test-%s-%s" % (browser, feature),
+        size = "large",
+        srcs = FEATURE_SUITE_DEFS[feature][0],
+        args = [
+            "--instafail",
+        ] + BROWSERS[browser]["args"],
+        data = BROWSERS[browser]["data"],
+        env_inherit = ["DISPLAY"],
+        tags = ["no-sandbox"] + BROWSERS[browser]["tags"],
+        target_compatible_with = BROWSERS[browser]["target_compatible_with"],
+        test_suffix = "%s-%s" % (browser, feature),
+        deps = [
+            ":init-tree",
+            ":webserver",
+            FEATURE_SUITE_DEFS[feature][1],
+        ] + BROWSER_TESTS[browser]["deps"] + TEST_DEPS,
+    )
+    for browser in DEFAULT_BROWSER_TESTS
+    for feature in FEATURE_SUITE_DEFS
+]
+
+# Aggregate test-<browser> = common + actions + features (keeps CI targets unchanged)
 [test_suite(
     name = "test-%s" % browser,
     tests = [
         ":test-%s-common" % browser,
         ":test-%s-actions" % browser,
-    ],
+    ] + [":test-%s-%s" % (browser, f) for f in FEATURE_SUITE_DEFS],
 ) for browser in DEFAULT_BROWSER_TESTS]
 
 # Generate test-<browser>-bidi-common targets
@@ -858,7 +953,7 @@ DEFAULT_BROWSER_TESTS = [b for b in BROWSER_TESTS if b != "ie"]
                 "test/selenium/webdriver/common/**/*.py",
                 "test/selenium/webdriver/support/**/*.py",
             ] + BROWSER_TESTS[browser]["browser_srcs"],
-            exclude = ACTIONS_TESTS + ["test/selenium/webdriver/common/print_pdf_tests.py"] +
+            exclude = ACTIONS_TESTS + FEATURE_TESTS + ["test/selenium/webdriver/common/print_pdf_tests.py"] +
                       BROWSER_TESTS[browser].get("extra_excludes", []),
         ),
         args = [
@@ -903,13 +998,39 @@ DEFAULT_BROWSER_TESTS = [b for b in BROWSER_TESTS if b != "ie"]
     if BROWSER_TESTS[browser].get("bidi", False)
 ]
 
-# Aggregate test-<browser>-bidi = bidi-common + bidi-actions
+# Generate test-<browser>-bidi-<feature> targets
+[
+    py_test_suite(
+        name = "test-%s-bidi-%s" % (browser, feature),
+        size = "large",
+        srcs = FEATURE_SUITE_DEFS[feature][0],
+        args = [
+            "--instafail",
+            "--bidi",
+        ] + BROWSERS[browser]["args"],
+        data = BROWSERS[browser]["data"],
+        env_inherit = ["DISPLAY"],
+        tags = ["no-sandbox"] + BROWSERS[browser]["tags"],
+        target_compatible_with = BROWSERS[browser]["target_compatible_with"],
+        test_suffix = "%s-bidi-%s" % (browser, feature),
+        deps = [
+            ":init-tree",
+            ":webserver",
+            FEATURE_SUITE_DEFS[feature][1],
+        ] + BROWSER_TESTS[browser]["deps"] + TEST_DEPS,
+    )
+    for browser in DEFAULT_BROWSER_TESTS
+    for feature in FEATURE_SUITE_DEFS
+    if BROWSER_TESTS[browser].get("bidi", False)
+]
+
+# Aggregate test-<browser>-bidi = bidi-common + bidi-actions + bidi-features
 [test_suite(
     name = "test-%s-bidi" % browser,
     tests = [
         ":test-%s-bidi-common" % browser,
         ":test-%s-bidi-actions" % browser,
-    ],
+    ] + [":test-%s-bidi-%s" % (browser, f) for f in FEATURE_SUITE_DEFS],
 ) for browser in DEFAULT_BROWSER_TESTS if BROWSER_TESTS[browser].get("bidi", False)]
 
 # Generate test-<browser>-remote-common targets (chrome and firefox only)
@@ -923,7 +1044,7 @@ DEFAULT_BROWSER_TESTS = [b for b in BROWSER_TESTS if b != "ie"]
                 "test/selenium/webdriver/remote/**/*.py",
                 "test/selenium/webdriver/support/**/*.py",
             ] + BROWSER_TESTS[browser]["browser_srcs"],
-            exclude = BIDI_TESTS + ACTIONS_TESTS + ["test/selenium/webdriver/common/print_pdf_tests.py"] +
+            exclude = BIDI_TESTS + ACTIONS_TESTS + FEATURE_TESTS + ["test/selenium/webdriver/common/print_pdf_tests.py"] +
                       BROWSER_TESTS[browser].get("extra_excludes", []),
         ),
         args = [
@@ -992,13 +1113,51 @@ DEFAULT_BROWSER_TESTS = [b for b in BROWSER_TESTS if b != "ie"]
     ]
 ]
 
-# Aggregate test-<browser>-remote = remote-common + remote-actions
+# Generate test-<browser>-remote-<feature> targets (chrome and firefox only)
+[
+    py_test_suite(
+        name = "test-%s-remote-%s" % (browser, feature),
+        size = "large",
+        srcs = FEATURE_SUITE_DEFS[feature][0],
+        args = [
+            "--instafail",
+            "--remote",
+        ] + BROWSERS[browser]["args"],
+        data = BROWSERS[browser]["data"] + [
+            ":java-location",
+            "//java/src/org/openqa/selenium/grid:selenium_server_deploy.jar",
+            "@bazel_tools//tools/jdk:current_java_runtime",
+        ],
+        env = {
+            "SE_BAZEL_JAVA_LOCATION": "$(rootpath :java-location)",
+        },
+        env_inherit = ["DISPLAY"],
+        tags = [
+            "no-sandbox",
+            "remote",
+            "%s-remote" % browser,
+        ],
+        test_suffix = "%s-remote-%s" % (browser, feature),
+        deps = [
+            ":init-tree",
+            ":webserver",
+            FEATURE_SUITE_DEFS[feature][1],
+        ] + BROWSER_TESTS[browser]["deps"] + TEST_DEPS,
+    )
+    for browser in [
+        "chrome",
+        "firefox",
+    ]
+    for feature in FEATURE_SUITE_DEFS
+]
+
+# Aggregate test-<browser>-remote = remote-common + remote-actions + remote-features
 [test_suite(
     name = "test-%s-remote" % browser,
     tests = [
         ":test-%s-remote-common" % browser,
         ":test-%s-remote-actions" % browser,
-    ],
+    ] + [":test-%s-remote-%s" % (browser, f) for f in FEATURE_SUITE_DEFS],
 ) for browser in [
     "chrome",
     "firefox",
@@ -1021,7 +1180,7 @@ py_test_suite(
             "test/selenium/webdriver/common/**/*.py",
             "test/selenium/webdriver/support/**/*.py",
         ],
-        exclude = BIDI_TESTS + ACTIONS_TESTS,
+        exclude = BIDI_TESTS + ACTIONS_TESTS + FEATURE_TESTS,
     ),
     args = [
         "--instafail",
@@ -1069,12 +1228,40 @@ py_test_suite(
     ] + TEST_DEPS,
 )
 
+[
+    py_test_suite(
+        name = "test-webkitgtk-%s" % feature,
+        size = "large",
+        srcs = FEATURE_SUITE_DEFS[feature][0],
+        args = [
+            "--instafail",
+            "--driver=webkitgtk",
+            "--browser-binary=MiniBrowser",
+            "--browser-args=--automation",
+        ],
+        tags = [
+            "exclusive-if-local",
+            "no-sandbox",
+            "skip-rbe",
+        ],
+        test_suffix = "webkitgtk-%s" % feature,
+        deps = [
+            ":init-tree",
+            ":support",
+            ":webkitgtk",
+            ":webserver",
+            FEATURE_SUITE_DEFS[feature][1],
+        ] + TEST_DEPS,
+    )
+    for feature in FEATURE_SUITE_DEFS
+]
+
 test_suite(
     name = "test-webkitgtk",
     tests = [
         ":test-webkitgtk-actions",
         ":test-webkitgtk-common",
-    ],
+    ] + [":test-webkitgtk-%s" % f for f in FEATURE_SUITE_DEFS],
 )
 
 py_test_suite(
@@ -1085,7 +1272,7 @@ py_test_suite(
             "test/selenium/webdriver/common/**/*.py",
             "test/selenium/webdriver/support/**/*.py",
         ],
-        exclude = BIDI_TESTS + ACTIONS_TESTS,
+        exclude = BIDI_TESTS + ACTIONS_TESTS + FEATURE_TESTS,
     ),
     args = [
         "--instafail",
@@ -1133,12 +1320,40 @@ py_test_suite(
     ] + TEST_DEPS,
 )
 
+[
+    py_test_suite(
+        name = "test-wpewebkit-%s" % feature,
+        size = "large",
+        srcs = FEATURE_SUITE_DEFS[feature][0],
+        args = [
+            "--instafail",
+            "--driver=wpewebkit",
+            "--browser-binary=MiniBrowser",
+            "--browser-args=--automation --headless",
+        ],
+        tags = [
+            "exclusive-if-local",
+            "no-sandbox",
+            "skip-rbe",
+        ],
+        test_suffix = "wpewebkit-%s" % feature,
+        deps = [
+            ":init-tree",
+            ":support",
+            ":webserver",
+            ":wpewebkit",
+            FEATURE_SUITE_DEFS[feature][1],
+        ] + TEST_DEPS,
+    )
+    for feature in FEATURE_SUITE_DEFS
+]
+
 test_suite(
     name = "test-wpewebkit",
     tests = [
         ":test-wpewebkit-actions",
         ":test-wpewebkit-common",
-    ],
+    ] + [":test-wpewebkit-%s" % f for f in FEATURE_SUITE_DEFS],
 )
 
 py_binary(