Commit ebcdc24
committed
Use native CC toolchains on Windows and macOS; restrict LLVM exec to Linux
The hermetic LLVM exec toolchains for Windows and macOS cause build failures:
- Windows: the minimal LLVM package ships only a GNU-mode clang++ that
rejects MSVC-style linker flags (/NOLOGO, backslash paths, .lib files)
generated by rustc for x86_64-pc-windows-msvc targets. Removing the
Windows LLVM exec toolchain registrations and keeping the existing
BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=0 override allows Bazel to detect
Visual Studio's link.exe on Windows runners.
- macOS: the hermetic LLVM sysroot lacks compiler-rt builtins at the path
aws-lc-sys's build script expects (configuration hash mismatch between the
build-script exec config and the main build config). It also lacks system
frameworks like CoreServices required by aws-lc-sys. Removing the macOS
LLVM exec toolchain registration and re-enabling Xcode CC detection
(BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=0, BAZEL_NO_APPLE_CPP_TOOLCHAIN=0)
lets macOS runners use Xcode clang which has full system access.
LLVM exec toolchains are kept only for Linux where they work correctly and
are required for the musl cross-compilation targets.1 parent 2c7c1c0 commit ebcdc24
2 files changed
Lines changed: 16 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
23 | 25 | | |
| 26 | + | |
| 27 | + | |
24 | 28 | | |
25 | 29 | | |
26 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
423 | 423 | | |
424 | 424 | | |
425 | 425 | | |
426 | | - | |
427 | | - | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
436 | | - | |
437 | | - | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
438 | 434 | | |
439 | 435 | | |
440 | 436 | | |
| |||
0 commit comments