Commit ef8c989
authored
rules_rs 0.0.90 bundles a newer rules_rust and pulls llvm 0.8.3, which
breaks the Selenium Manager build in three ways:
1. The cargo build-script runner now rejects libtool as the archiver
(AR). macOS C++ toolchains (autodetected and apple_support alike) use
libtool by default, breaking every Rust crate with a build script.
Fix: register the hermetic @llvm toolchain for macOS exec (mirroring
Windows) and, on macOS, disable C++ toolchain autodetection and switch
the rules_cc archiver from libtool to llvm-ar.
2. The selenium-manager binary fails to compile because clap's
#[clap(about)] derives the description from CARGO_PKG_DESCRIPTION,
which rules_rust no longer sets. Fix: set it via rustc_env, kept in
sync with rust/Cargo.toml.
3. On Windows, no Rust toolchain matches //:local_windows_gnullvm: the
gnullvm toolchain now requires crt:msvcrt, but the crt constraint
defaults to ucrt. Fix: select msvcrt explicitly on the platform.
Also pins llvm to 0.8.3 to match the resolved version. Linux is
unaffected.
1 parent cd6a3cd commit ef8c989
4 files changed
Lines changed: 28 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
93 | 100 | | |
94 | 101 | | |
95 | 102 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| 132 | + | |
132 | 133 | | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
133 | 138 | | |
134 | 139 | | |
135 | 140 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
399 | 399 | | |
400 | 400 | | |
401 | 401 | | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
402 | 410 | | |
403 | 411 | | |
404 | 412 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
81 | 87 | | |
82 | 88 | | |
83 | 89 | | |
| |||
0 commit comments