Skip to content

[rust] Reuse constant for --version #17579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bonigarcia merged 1 commit into from
May 27, 2026
Merged

[rust] Reuse constant for --version #17579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions rust/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,8 +659,10 @@ pub trait SeleniumManager {
}

fn find_driver_in_path(&self) -> (Option<String>, Option<String>) {
let driver_version_command =
Command::new(self.get_driver_name(), vec![String::from("--version")]);
let driver_version_command = Command::new(
self.get_driver_name(),
vec![String::from(DASH_DASH_VERSION)],
);
match run_shell_command(driver_version_command) {
Ok(output) => {
let parsed_version = parse_version(output, self.get_logger()).unwrap_or_default();
Expand Down
4 changes: 3 additions & 1 deletion rust/tests/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
use assert_cmd::Command;
use assert_cmd::assert::AssertResult;
use is_executable::is_executable;
use selenium_manager::DASH_DASH_VERSION;
use selenium_manager::files::path_to_string;
use selenium_manager::logger::JsonOutput;
use selenium_manager::shell;
Expand Down Expand Up @@ -81,7 +82,8 @@ pub fn get_driver_path(cmd: &mut Command) -> String {
pub fn exec_driver(cmd: &mut Command) -> String {
let cmd_mut = cmd.borrow_mut();
let driver_path = get_driver_path(cmd_mut);
let driver_version_command = shell::Command::new(&driver_path, vec![String::from("--version")]);
let driver_version_command =
shell::Command::new(&driver_path, vec![String::from(DASH_DASH_VERSION)]);
let output = run_shell_command(driver_version_command).unwrap();
println!("**** EXEC DRIVER: {}", output);
output
Expand Down
Loading