Skip to content

[build] Combine Rust build and test CI jobs#17612

Merged
titusfortner merged 1 commit into
trunkfrom
c/rust_build
Jun 2, 2026
Merged

[build] Combine Rust build and test CI jobs#17612
titusfortner merged 1 commit into
trunkfrom
c/rust_build

Conversation

@titusfortner
Copy link
Copy Markdown
Member

💥 What does this PR do?

Combines the separate build job into the tests job in the Rust CI workflow (.github/workflows/ci-rust.yml).

Previously there was a standalone build job running bazel build //rust:selenium-manager, with the tests matrix gated on it via needs: build.
Since bazel test //rust/... already compiles //rust:selenium-manager (and the rest of the tree) when producing the test binaries, the dedicated build job was redundant. It has been removed and tests now runs directly.

This should save ~3-4 minutes wall clock on runs.

🔧 Implementation Notes

The old build job provided a fast, single-platform (ubuntu) "does it compile" gate before fanning out to the 3-OS test matrix. With it removed, a compile error now surfaces from all three matrix legs in parallel instead of gating on one cheap build first — functionally equivalent, with slightly more runner usage on a broken build. Downstream platform jobs still needs: tests, so the overall ordering is preserved.

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s): Claude Code
    • What was generated:
    • I reviewed all AI output and can explain the change

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Jun 2, 2026
@qodo-code-review
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Remove redundant Rust build job from CI workflow

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Removes redundant standalone build job from CI workflow
• Eliminates unnecessary compilation gate before test matrix
• Reduces CI runtime by ~3-4 minutes per workflow run
• Tests job now runs directly without build dependency
Diagram
flowchart LR
  A["CI Workflow"] --> B["Tests Job<br/>3-OS Matrix"]
  B --> C["Compile & Test<br/>All Platforms"]
  style A fill:#e1f5ff
  style B fill:#c8e6c9
  style C fill:#fff9c4

Loading

Grey Divider

File Changes

1. .github/workflows/ci-rust.yml ⚙️ Configuration changes +0/-8

Eliminate redundant build job from Rust CI

• Removed standalone build job that ran bazel build //rust:selenium-manager
• Removed needs: build dependency from tests job
• Tests job now runs directly without build gate
• Compilation still occurs during bazel test //rust/... execution

.github/workflows/ci-rust.yml


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented Jun 2, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Previous review results

Review updated until commit a98e0ea

Results up to commit cb313c8


🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review Bot commented Jun 2, 2026

Code review by qodo was updated up to the latest commit a98e0ea

@titusfortner titusfortner merged commit 1a85379 into trunk Jun 2, 2026
26 checks passed
@titusfortner titusfortner deleted the c/rust_build branch June 2, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants