[build] Combine Rust build and test CI jobs#17612
Merged
Merged
Conversation
Contributor
Review Summary by QodoRemove redundant Rust build job from CI workflow
WalkthroughsDescription• Removes redundant standalone build job from CI workflow • Eliminates unnecessary compilation gate before test matrix • Reduces CI runtime by ~3-4 minutes per workflow run • Tests job now runs directly without build dependency Diagramflowchart LR
A["CI Workflow"] --> B["Tests Job<br/>3-OS Matrix"]
B --> C["Compile & Test<br/>All Platforms"]
style A fill:#e1f5ff
style B fill:#c8e6c9
style C fill:#fff9c4
File Changes1. .github/workflows/ci-rust.yml
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewPrevious review resultsReview updated until commit a98e0ea Results up to commit cb313c8
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
cb313c8 to
a98e0ea
Compare
Contributor
|
Code review by qodo was updated up to the latest commit a98e0ea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💥 What does this PR do?
Combines the separate
buildjob into thetestsjob in the Rust CI workflow (.github/workflows/ci-rust.yml).Previously there was a standalone
buildjob runningbazel build //rust:selenium-manager, with thetestsmatrix gated on it vianeeds: build.Since
bazel test //rust/...already compiles//rust:selenium-manager(and the rest of the tree) when producing the test binaries, the dedicated build job was redundant. It has been removed andtestsnow runs directly.This should save ~3-4 minutes wall clock on runs.
🔧 Implementation Notes
The old
buildjob provided a fast, single-platform (ubuntu) "does it compile" gate before fanning out to the 3-OS test matrix. With it removed, a compile error now surfaces from all three matrix legs in parallel instead of gating on one cheap build first — functionally equivalent, with slightly more runner usage on a broken build. Downstream platform jobs stillneeds: tests, so the overall ordering is preserved.🤖 AI assistance
💡 Additional Considerations
🔄 Types of changes