Build: PR-iteration history for cross-commit peak attribution#152
Merged
Build: PR-iteration history for cross-commit peak attribution#152
Conversation
Walk prior bench runs on this PR's branch to build a per-iteration history. The reporter merges it with bench-history.json (main commits) so peak attribution spans BOTH main AND this PR's iterations. An agent iterating on a perf branch now sees: "create-1k peaked at 104.7ms on commit 9bcd3f1 (iteration 10), now at 143.9ms (+37%). Bisect candidates: 442446e, 64c6820, 5595cbd +7 more." New files: - tools/bench-reporter/fetch-pr-history.js — walks gh API for prior successful Benchmarks runs on the PR branch, downloads results-* artifacts, extracts this-change absolute CIs, outputs pr-history.json in bench-history.json schema. Changed files: - reporter.js — new --pr-history flag, mergeHistories() combines main + PR iteration histories sorted by timestamp with SHA dedup. The existing computeHistoryStatus + REOPENED rendering work unchanged. - benchmarks-report.yml — new "Fetch PR iteration history" step before "Generate report" in the comment job. Uses the bot token for API auth. Tested against PR #148's 17 prior runs: 13 REOPENED metrics surfaced with correct peak attribution and bisect candidates.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Walk prior bench runs on this PR's branch to build a per-iteration history. The reporter merges it with bench-history.json (main commits) so peak attribution spans BOTH main AND this PR's iterations.
An agent iterating on a perf branch now sees: "create-1k peaked at 104.7ms on commit 9bcd3f1 (iteration 10), now at 143.9ms (+37%). Bisect candidates: 442446e, 64c6820, 5595cbd +7 more."