Bug: Fix Regression from Peak to Have Statistical Significance#178
Merged
Bug: Fix Regression from Peak to Have Statistical Significance#178
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…dual comment sweep
…op unused exports, comment trims
jlukic
changed the title
github-actions
Bot
added
CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Bench Peak Attribution.
This PR is designed to fix issues with "regressions from peak" incorrectly using absolute differences instead of % differences.
This was a logical error because tachometer does not provide absolute benchmarks but instead can give you a valid % regressions from a baseline SHA. The previous reporter was using absolute differences as having statistical merit which is not scientifically rigorous.
Changes
driftifmainhas changed significantly between test runs on the same PR. This is designed to provide enough information to determine whether regressions represent changes in the PR versus changes in mainRisk
1/10 — internal CI infrastructure.
Cannot know for certain if PR is valid until it merges into main so CI can run meaningful tests on a PR.
How to Test
Check next meaningful code PR and confirm CI runs correctly with new script.