Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
jlukic
changed the title
jlukic
changed the title
…NewPeaks into renderPeakSection
The verb 'improved' already encodes direction; 'improved -25%' read as contradicting itself. Use Math.abs so the cell renders 'improved 25%' to mirror the regression side's 'regressed +25%' framing.
The pp initialism reads as jargon (no engineer says "pp" aloud); standardise on % everywhere in comments. Em-dashes in PR-added prose comments swap to period or colon depending on whether the clause continues a thought or introduces a list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bench bot surfaces regression-from-peak signals but does not show WIN and TIED-PEAK, only in the JSON in the test runner.
For perf work that iterates, the affirmative signal matters as much as the regression signal. "This iteration is the new peak" is what tells an agent the change worked.
This PR mirrors the existing
Regressions from peaksection withNew peaksfor the affirmative case.Changes
N new peakscount and aNew peakstable mirroring the regressions section.%.Risk
0/10 — internal CI infrastructure. No public code touched.