Skip to content

Bench: Remove clean-heap and forced-GC krausest probes #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlukic merged 1 commit into from
Jun 5, 2026
Merged

Bench: Remove clean-heap and forced-GC krausest probes #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 0 additions & 55 deletions packages/component/bench/tachometer/bench-krausest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,36 +206,6 @@ function getRows(el) {
return el.component.getRows();
}

/*******************************
Update (clean heap)
Same workload as update-10th-50 but run first, before the
create-heavy ops, so the measured region starts on a clean heap.
The delta against update-10th-50 isolates suite-ordering GC cost.
*******************************/

// Warm render / reconcile / update so the first-op cold JIT doesn't
// skew the isolated measure.
const elWarm = await mount();
elWarm.component.run(1000);
await flush();
for (let i = 0; i < 10; i++) {
elWarm.component.update();
flushWork();
}
destroy();

const elIso = await mount();
elIso.component.run(1000);
await flush();
// purpose: Same update workload as update-10th-50 but on a clean heap with no create-heavy ops before it. Pairs with update-10th-50 to isolate suite-ordering GC pressure.
performance.mark(startMark('update-isolated-50'));
for (let i = 0; i < 50; i++) {
elIso.component.update();
flushWork();
}
performance.measure('update-isolated-50', startMark('update-isolated-50'));
destroy();

/*******************************
Create
(krausest 01_run, 02b_runlots)
Expand Down Expand Up @@ -309,31 +279,6 @@ for (let i = 0; i < 50; i++) {
performance.measure('update-10th-50', startMark('update-10th-50'));
destroy();

/*******************************
Update (forced GC)
update-10th workload with a full GC before the measured region.
If the update-10th-50 delta vanishes here, the carried-in cost is
reclaimable GC pressure from the create-heavy ops above.
*******************************/

const el5b = await mount();
el5b.component.run(1000);
await flush();
// gc() exists only under --js-flags=--expose-gc (set in tachometer-ci-krausest.json).
// Settle after collecting so the measured region starts on a post-GC heap.
if (globalThis.gc) {
globalThis.gc();
await flush();
}
// purpose: update-10th workload with a forced GC before the measured region. If the update-10th-50 regression vanishes here it is reclaimable GC pressure.
performance.mark(startMark('update-gc-50'));
for (let i = 0; i < 50; i++) {
el5b.component.update();
flushWork();
}
performance.measure('update-gc-50', startMark('update-gc-50'));
destroy();

/*******************************
Select
(krausest 05_select)
Expand Down
8 changes: 2 additions & 6 deletions packages/component/bench/tachometer/tachometer-ci-krausest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,13 @@
{
"name": "this-change",
"url": "ci-current-krausest.html",
"browser": { "name": "chrome", "headless": true, "addArguments": ["--js-flags=--expose-gc"] },
"browser": { "name": "chrome", "headless": true },
"measurement": [
{ "mode": "performance", "entryName": "create-1k" },
{ "mode": "performance", "entryName": "create-10k" },
{ "mode": "performance", "entryName": "replace-1k" },
{ "mode": "performance", "entryName": "append-1k" },
{ "mode": "performance", "entryName": "update-10th-50" },
{ "mode": "performance", "entryName": "update-isolated-50" },
{ "mode": "performance", "entryName": "update-gc-50" },
{ "mode": "performance", "entryName": "select-40" },
{ "mode": "performance", "entryName": "swap-rows-20" },
{ "mode": "performance", "entryName": "remove-row-front-20" },
Expand All @@ -28,15 +26,13 @@
{
"name": "tip-of-tree",
"url": "ci-baseline-krausest.html",
"browser": { "name": "chrome", "headless": true, "addArguments": ["--js-flags=--expose-gc"] },
"browser": { "name": "chrome", "headless": true },
"measurement": [
{ "mode": "performance", "entryName": "create-1k" },
{ "mode": "performance", "entryName": "create-10k" },
{ "mode": "performance", "entryName": "replace-1k" },
{ "mode": "performance", "entryName": "append-1k" },
{ "mode": "performance", "entryName": "update-10th-50" },
{ "mode": "performance", "entryName": "update-isolated-50" },
{ "mode": "performance", "entryName": "update-gc-50" },
{ "mode": "performance", "entryName": "select-40" },
{ "mode": "performance", "entryName": "swap-rows-20" },
{ "mode": "performance", "entryName": "remove-row-front-20" },
Expand Down
Loading