Skip to content

fix(TransitionablePortal): fix onClose call#4334

Open
mterezac wants to merge 1 commit intoSemantic-Org:masterfrom
mterezac:fix-transitionable-portal-onclose
Open

fix(TransitionablePortal): fix onClose call#4334
mterezac wants to merge 1 commit intoSemantic-Org:masterfrom
mterezac:fix-transitionable-portal-onclose

Conversation

@mterezac
Copy link
Copy Markdown

Fixes #4056.

@welcome
Copy link
Copy Markdown

welcome bot commented Feb 15, 2022

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 15, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.75%. Comparing base (bb2db59) to head (1fe1aac).
⚠️ Report is 76 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4334   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         180      180           
  Lines        3241     3243    +2     
=======================================
+ Hits         3233     3235    +2     
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TransitionablePortal: onClose is called even on button click when controlled

2 participants