Skip to content

Fix StrictTextAreaProps value field#4485

Open
lakshayv13 wants to merge 2 commits into
Semantic-Org:masterfrom
lakshayv13:main
Open

Fix StrictTextAreaProps value field#4485
lakshayv13 wants to merge 2 commits into
Semantic-Org:masterfrom
lakshayv13:main

Conversation

@lakshayv13

@lakshayv13 lakshayv13 commented Jun 23, 2024

Copy link
Copy Markdown

FIxed the issue #4464

@welcome

welcome Bot commented Jun 23, 2024

Copy link
Copy Markdown

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@vercel

vercel Bot commented Jun 23, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semantic-ui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 6:22pm

@codecov

codecov Bot commented Jun 23, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.50%. Comparing base (1623c8d) to head (2a663ef).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4485   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files         186      186           
  Lines        3465     3465           
=======================================
  Hits         3448     3448           
  Misses         17       17           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant