Skip to content

Commit 9bfdf6c

Browse files
committed
Run rc publishing through repo-local CI tools
The first rc workflow run exposed two CI-only release hazards: the generic publish workflow would still match prerelease tags, and GitHub runner global tools made npm/tsc resolution brittle. The release workflows now avoid npm self-upgrade, the stable publisher skips prerelease tags, and CI invokes the repo-local TypeScript/test commands. Constraint: RC publishing must happen from CI without promoting latest Rejected: Keep using global tsc | runner versions produced false TypeScript failures despite local dependencies being installed Rejected: npm install -g npm@latest | runner npm self-upgrade failed before validation could run Confidence: high Scope-risk: narrow Tested: npm exec tsc -- --noEmit; npm run check; YAML parse for CI/publish/rc-release workflows; prettier --check .github/workflows/*.yml Not-tested: Successful CI publish after tag repush
1 parent 66217bd commit 9bfdf6c

3 files changed

Lines changed: 3 additions & 5 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ jobs:
2121
node-version: ${{ matrix.node-version }}
2222
cache: npm
2323
- run: npm ci
24-
- run: tsc --noEmit
24+
- run: npm exec tsc -- --noEmit
2525
- run: npm run lint
2626
- run: npm run format:check
27-
- run: npx vitest run
27+
- run: npm test
2828
- name: Coverage report
2929
if: matrix.node-version == 22
3030
run: npx vitest run --coverage --test-timeout=30000
@@ -39,7 +39,7 @@ jobs:
3939
node-version: 22
4040
cache: npm
4141
- run: npm ci
42-
- run: tsc
42+
- run: npm run build
4343
- name: Verify CLI entry point exists
4444
run: test -f dist/packages/cli/index.js
4545
- name: Smoke test

.github/workflows/publish.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ jobs:
1818
node-version: 22
1919
cache: npm
2020
registry-url: https://registry.npmjs.org
21-
- run: npm install -g npm@latest
2221
- run: npm ci
2322
- run: npm run build
2423
- run: npx vitest run

.github/workflows/rc-release.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ jobs:
4444
node-version: 22
4545
cache: npm
4646
registry-url: https://registry.npmjs.org
47-
- run: npm install -g npm@latest
4847
- run: npm ci
4948
- name: Verify RC tag and package metadata
5049
run: |

0 commit comments

Comments
 (0)