Skip to content

Commit 2291758

Browse files
authored
fix: update precision for known issue warning (#440)
* fix: wrong precision on known issue * chore: update related test
1 parent a417e21 commit 2291758

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

packages/app/src/lib/known-issues.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ import { KNOWN_CONFIG_ISSUES, knownIssueCsvNote, matchKnownConfigIssues } from '
55
const DSR1 = 'DeepSeek-R1-0528';
66

77
describe('matchKnownConfigIssues', () => {
8-
it('matches the GB300 Dynamo TRT MTP entry for DeepSeek R1 FP4', () => {
8+
it('matches the GB300 Dynamo TRT MTP entry for DeepSeek R1 FP8', () => {
99
const issues = matchKnownConfigIssues(DSR1, [
10-
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp4' },
10+
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp8' },
1111
]);
1212
expect(issues).toHaveLength(1);
1313
expect(issues[0].url).toBe('https://github.com/NVIDIA/srt-slurm/issues/51');
1414
});
1515

16-
it('does not match GB300 Dynamo TRT MTP for non-FP4 precisions', () => {
16+
it('does not match GB300 Dynamo TRT MTP for non-FP8 precisions', () => {
1717
const issues = matchKnownConfigIssues(DSR1, [
18-
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp8' },
18+
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp4' },
1919
]);
2020
expect(issues).toHaveLength(0);
2121
});
@@ -47,8 +47,8 @@ describe('matchKnownConfigIssues', () => {
4747

4848
it('returns each issue at most once even with many matching points', () => {
4949
const issues = matchKnownConfigIssues(DSR1, [
50-
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp4' },
51-
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp4' },
50+
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp8' },
51+
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp8' },
5252
{ hwKey: 'mi355x_mori-sglang_mtp', precision: 'fp4' },
5353
]);
5454
expect(issues).toHaveLength(2);

packages/app/src/lib/known-issues.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export const KNOWN_CONFIG_ISSUES: KnownConfigIssue[] = [
2929
{
3030
hwKey: 'gb300_dynamo-trt_mtp',
3131
model: Model.DeepSeek_R1,
32-
precisions: ['fp4'],
32+
precisions: ['fp8'],
3333
summary: 'Accuracy issues',
3434
filed: 'Apr 21, 2026',
3535
url: 'https://github.com/NVIDIA/srt-slurm/issues/51',

0 commit comments

Comments
 (0)