Skip to content

Commit 3c73c14

Browse files
fix(e2e): pair i_prec=fp8 URL with a model that has FP8 in fixtures
After PR #435 made DeepSeek-V4-Pro the default model, the refreshed availability fixture (which includes only FP4 for dsv4) caused `effectivePrecisions` to intersect the URL-seeded ['fp8'] with the available set and fall back to FP4. The precision-multiselect then rendered FP4 instead of the expected FP8. Add `g_model=DeepSeek-R1-0528` to the two affected specs so the URL selection is meaningful — matching the workaround already used by the "multiple URL params" test in url-params.cy.ts. Co-authored-by: Alec Ibarra <adibarra@users.noreply.github.com>
1 parent f4c488a commit 3c73c14

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

packages/app/cypress/e2e/line-labels.cy.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,11 @@ describe('Line Labels Toggle', () => {
8080
});
8181

8282
it('appends the precision to each line label when multiple precisions are selected', () => {
83-
cy.visit('/inference?i_linelabel=1&i_prec=fp4,fp8', {
83+
// Pair the FP4+FP8 selection with a model that has both precisions in the
84+
// fixtures. The default model (DeepSeek-V4-Pro) only has FP4, so
85+
// `effectivePrecisions` would drop FP8 and the test couldn't observe the
86+
// dual-precision labeling behavior.
87+
cy.visit('/inference?g_model=DeepSeek-R1-0528&i_linelabel=1&i_prec=fp4,fp8', {
8488
onBeforeLoad(win) {
8589
win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
8690
},

packages/app/cypress/e2e/url-params.cy.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,11 @@ describe('URL Parameter Persistence', () => {
186186
});
187187

188188
it('/inference?i_prec=fp8 seeds the precision without a hydration error', () => {
189-
visitWithErrorSpy('/inference?i_prec=fp8');
189+
// Pair `i_prec=fp8` with a model that actually has FP8 in availability.
190+
// The default model (DeepSeek-V4-Pro) is FP4-only in the test fixtures,
191+
// so `effectivePrecisions` would otherwise intersect the URL selection
192+
// with the available set and fall back to FP4.
193+
visitWithErrorSpy('/inference?g_model=DeepSeek-R1-0528&i_prec=fp8');
190194
cy.get('[data-testid="precision-multiselect"]').should('contain.text', 'FP8');
191195
assertNoHydrationMismatch();
192196
});

0 commit comments

Comments
 (0)