Skip to content

Commit 831bac1

Browse files
committed
remove tautological tests (renders/exists checks with no behavioral value)
1 parent 963f3ee commit 831bac1

8 files changed

Lines changed: 6 additions & 131 deletions

File tree

packages/app/cypress/component/chart-buttons.cy.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,6 @@ describe('ChartButtons', () => {
1111
);
1212
});
1313

14-
it('renders export button', () => {
15-
cy.get('[data-testid="export-button"]').should('be.visible');
16-
});
17-
18-
it('renders zoom reset button', () => {
19-
cy.get('[data-testid="zoom-reset-button"]').should('be.visible');
20-
});
21-
2214
it('zoom reset dispatches custom event', () => {
2315
cy.window().then((win) => {
2416
const handler = cy.stub().as('zoomReset');

packages/app/cypress/component/chart-selectors.cy.tsx

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import { useState } from 'react';
22

3-
import { ModelSelector, SequenceSelector, PrecisionSelector } from '@/components/ui/chart-selectors';
3+
import {
4+
ModelSelector,
5+
SequenceSelector,
6+
PrecisionSelector,
7+
} from '@/components/ui/chart-selectors';
48
import { TooltipProvider } from '@/components/ui/tooltip';
59

610
function ModelSelectorHarness() {
@@ -51,10 +55,6 @@ describe('Chart Selectors', () => {
5155
cy.mount(<ModelSelectorHarness />);
5256
});
5357

54-
it('renders with data-testid', () => {
55-
cy.get('[data-testid="model-selector"]').should('be.visible');
56-
});
57-
5858
it('shows options when clicked', () => {
5959
cy.get('[data-testid="model-selector"]').click();
6060
cy.get('[role="option"]').should('have.length.greaterThan', 0);
@@ -72,10 +72,6 @@ describe('Chart Selectors', () => {
7272
cy.mount(<SequenceSelectorHarness />);
7373
});
7474

75-
it('renders with data-testid', () => {
76-
cy.get('[data-testid="sequence-selector"]').should('be.visible');
77-
});
78-
7975
it('shows options when clicked', () => {
8076
cy.get('[data-testid="sequence-selector"]').click();
8177
cy.get('[role="option"]').should('have.length', 3);
@@ -93,10 +89,6 @@ describe('Chart Selectors', () => {
9389
cy.mount(<PrecisionSelectorHarness />);
9490
});
9591

96-
it('renders with data-testid', () => {
97-
cy.get('[data-testid="precision-multiselect"]').should('be.visible');
98-
});
99-
10092
it('shows current selection', () => {
10193
cy.get('[data-testid="precision-multiselect"]').should('contain', 'FP8');
10294
});

packages/app/cypress/component/date-range-picker.cy.tsx

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@ function DateRangePickerHarness({
1919
placeholder="Select date range"
2020
/>
2121
<div data-testid="date-range-output">
22-
{range.startDate && range.endDate
23-
? `${range.startDate} to ${range.endDate}`
24-
: 'no range'}
22+
{range.startDate && range.endDate ? `${range.startDate} to ${range.endDate}` : 'no range'}
2523
</div>
2624
</div>
2725
);
@@ -40,13 +38,6 @@ describe('DateRangePicker', () => {
4038
cy.contains('Select Date Range').should('be.visible');
4139
});
4240

43-
it('shows cancel and apply buttons in dialog', () => {
44-
cy.mount(<DateRangePickerHarness />);
45-
cy.contains('Select date range').click();
46-
cy.contains('button', 'Cancel').should('be.visible');
47-
cy.contains('button', 'Apply').should('be.visible');
48-
});
49-
5041
it('apply is disabled when no dates selected', () => {
5142
cy.mount(<DateRangePickerHarness />);
5243
cy.contains('Select date range').click();

packages/app/cypress/component/footer.cy.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@ describe('Footer', () => {
1515
);
1616
});
1717

18-
it('renders the footer element', () => {
19-
cy.get('[data-testid="footer"]').should('exist');
20-
});
21-
2218
it('displays copyright notice with semianalysis.com and current year', () => {
2319
const year = new Date().getFullYear().toString();
2420
cy.get('[data-testid="footer-copyright"]').should('contain', 'semianalysis.com');
@@ -58,10 +54,6 @@ describe('Footer', () => {
5854
.and('include', 'github.com/SemiAnalysisAI/InferenceX-app');
5955
});
6056

61-
it('shows the SemiAnalysis logo', () => {
62-
cy.get('[data-testid="footer-brand"]').find('img[alt="SemiAnalysis logo"]').should('exist');
63-
});
64-
6557
it('all external links open in a new tab', () => {
6658
cy.get('[data-testid="footer-links"]')
6759
.find('a[target="_blank"]')

packages/app/cypress/component/header.cy.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ describe('Header', () => {
1818
);
1919
});
2020

21-
it('renders the header element', () => {
22-
cy.get('[data-testid="header"]').should('be.visible');
23-
});
24-
2521
it('displays the InferenceX title', () => {
2622
cy.get('[data-testid="header"]').contains('InferenceX').should('be.visible');
2723
});
@@ -52,10 +48,6 @@ describe('Header', () => {
5248
.and('include', 'github.com/SemiAnalysisAI/InferenceX');
5349
});
5450

55-
it('GitHub stars button has glow animation class', () => {
56-
cy.get('[data-testid="header-star-button"]').should('have.class', 'star-button-glow');
57-
});
58-
5951
it('shows the theme toggle button', () => {
6052
cy.get('[data-testid="theme-toggle"]').should('be.visible');
6153
});

packages/app/cypress/component/intro-section.cy.tsx

Lines changed: 0 additions & 47 deletions
This file was deleted.

packages/app/cypress/component/mode-toggle.cy.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,6 @@ describe('ModeToggle', () => {
1010
);
1111
});
1212

13-
it('renders the theme toggle button', () => {
14-
cy.get('[data-testid="theme-toggle"]').should('be.visible');
15-
});
16-
17-
it('has accessible aria-label', () => {
18-
cy.get('[data-testid="theme-toggle"]').should('have.attr', 'aria-label');
19-
});
20-
2113
it('clicking toggle switches to dark mode', () => {
2214
cy.get('html').should('not.have.class', 'dark');
2315
cy.get('[data-testid="theme-toggle"]').click();

packages/app/cypress/component/social-share.cy.tsx

Lines changed: 0 additions & 29 deletions
This file was deleted.

0 commit comments

Comments
 (0)