fix(inference): use agentic label defaults / 修正 agentic 标签默认值 (#545)

cquil11 · web-flow · commit 9ec8cc173400 · 2026-07-09T18:28:40.000-05:00
* fix(inference): use agentic label defaults

Apply scenario-aware defaults so agentic charts show parallelism labels and hide line labels, while fixed-sequence behavior remains unchanged. Preserve explicit and legacy URL overrides with scenario-aware serialization.

中文：修正推理图表的 agentic 标签默认值

按场景应用默认配置：agentic 图表默认显示并行配置标签并隐藏曲线标签，同时保持固定序列场景的现有行为不变。通过按场景序列化参数，继续兼容显式及旧版 URL 覆盖。

* test(inference): cover scenario label defaults

Add focused regression coverage for agentic and fixed-sequence label defaults, explicit URL overrides, and fixed-sequence URL serialization.

中文：补充推理场景标签默认值测试

新增定向回归测试，覆盖 agentic 与固定序列场景的标签默认值、显式 URL 覆盖及固定序列 URL 序列化。
diff --git a/packages/app/cypress/e2e/ttft-x-axis-toggle.cy.ts b/packages/app/cypress/e2e/ttft-x-axis-toggle.cy.ts
@@ -123,11 +123,24 @@ const agenticBenchmarks = agenticGpus.flatMap((g) =>
   })),
 );
 
+const fixedSequenceBenchmarks = agenticBenchmarks.map((row, index) => ({
+  ...row,
+  id: 910000 + index,
+  isl: 8192,
+  osl: 1024,
+  benchmark_type: 'single_turn',
+}));
+
 const interceptAgenticData = () => {
   cy.intercept('GET', '/api/v1/availability', { body: agenticAvailability }).as('availability');
   cy.intercept('GET', '/api/v1/benchmarks*', { body: agenticBenchmarks }).as('benchmarks');
 };
 
+const interceptFixedSequenceData = () => {
+  cy.intercept('GET', '/api/v1/availability', { body: agenticAvailability }).as('availability');
+  cy.intercept('GET', '/api/v1/benchmarks*', { body: fixedSequenceBenchmarks }).as('benchmarks');
+};
+
 describe('X-Axis Mode Toggle (inference chart)', () => {
   before(() => {
     interceptAgenticData();
@@ -152,6 +165,26 @@ describe('X-Axis Mode Toggle (inference chart)', () => {
     cy.get('[data-testid="chart-figure"] h2').should('contain.text', 'Interactivity');
   });
 
+  it('defaults to parallelism labels without line labels for the agentic view', () => {
+    cy.get('#scatter-parallelism-labels').should('have.attr', 'data-state', 'checked');
+    cy.get('#scatter-point-labels').should('have.attr', 'data-state', 'checked');
+    cy.get('#scatter-line-labels').should('have.attr', 'data-state', 'unchecked');
+  });
+
+  it('honors explicit label URL overrides for the agentic view', () => {
+    interceptAgenticData();
+    cy.visit('/inference?i_label=0&i_advlabel=0&i_linelabel=1', {
+      onBeforeLoad(win) {
+        win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
+        unlockAgenticGate(win);
+      },
+    });
+    cy.get('[data-testid="scenario-selector"]').should('contain.text', 'Agentic Traces');
+    cy.get('#scatter-parallelism-labels').should('have.attr', 'data-state', 'unchecked');
+    cy.get('#scatter-point-labels').should('have.attr', 'data-state', 'unchecked');
+    cy.get('#scatter-line-labels').should('have.attr', 'data-state', 'checked');
+  });
+
   it('switches the x-axis to TTFT and updates the heading', () => {
     cy.get('[data-testid="x-axis-mode-ttft"]').click();
     cy.get('[data-testid="x-axis-mode-ttft"]').should('have.attr', 'aria-selected', 'true');
@@ -201,6 +234,34 @@ describe('X-Axis Mode Toggle (inference chart)', () => {
   });
 });
 
+describe('Label defaults for fixed-sequence scenarios', () => {
+  it('keeps parallelism labels off and line labels on by default', () => {
+    interceptFixedSequenceData();
+    cy.visit('/inference?i_seq=8k%2F1k', {
+      onBeforeLoad(win) {
+        win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
+      },
+    });
+    cy.get('[data-testid="scenario-selector"]').should('contain.text', '8K / 1K');
+    cy.get('#scatter-parallelism-labels').should('have.attr', 'data-state', 'unchecked');
+    cy.get('#scatter-point-labels').should('have.attr', 'data-state', 'unchecked');
+    cy.get('#scatter-line-labels').should('have.attr', 'data-state', 'checked');
+  });
+
+  it('honors explicit label URL overrides', () => {
+    interceptFixedSequenceData();
+    cy.visit('/inference?i_seq=8k%2F1k&i_label=1&i_advlabel=1&i_linelabel=0', {
+      onBeforeLoad(win) {
+        win.localStorage.setItem('inferencex-star-modal-dismissed', String(Date.now()));
+      },
+    });
+    cy.get('[data-testid="scenario-selector"]').should('contain.text', '8K / 1K');
+    cy.get('#scatter-parallelism-labels').should('have.attr', 'data-state', 'checked');
+    cy.get('#scatter-point-labels').should('have.attr', 'data-state', 'checked');
+    cy.get('#scatter-line-labels').should('have.attr', 'data-state', 'unchecked');
+  });
+});
+
 // ---------------------------------------------------------------------------
 // Overlay path — regression coverage for unofficial-run overlays with agentic
 // x-axis modes (finding #8 / AGENTS.md: chart features must have overlay tests).
diff --git a/packages/app/src/components/inference/InferenceContext.tsx b/packages/app/src/components/inference/InferenceContext.tsx
@@ -64,6 +64,7 @@ import {
   type XAxisMode,
 } from './hooks/useChartData';
 import { resolveComparisonEntries } from './utils/comparisonEntry';
+import { resolveLabelState, serializeLabelState } from './utils/label-defaults';
 import {
   EMPTY_QUICK_FILTERS,
   type DisaggMode,
@@ -244,30 +245,24 @@ export function InferenceProvider({
   });
 
   const [hideNonOptimal, setHideNonOptimal] = useState(() => getUrlParam('i_optimal') !== '0');
-  const [showPointLabels, setShowPointLabels] = useState(() => {
-    // Legacy `?i_nolabel=1` from before the rename: keep hiding point labels.
-    if (getUrlParam('i_nolabel') === '1') return false;
-    if (getUrlParam('i_label') === '0') return false;
-    if (getUrlParam('i_label') === '1') return true;
-    // Advanced (parallelism) labels are a richer form of point label; a share
-    // link that requests them must auto-enable point labels so they actually
-    // render (mirrors the runtime toggle coupling in ScatterGraph). A later
-    // explicit i_nolabel=1 still wins — it is checked first above.
-    if (getUrlParam('i_advlabel') === '1') return true;
-    // Default off: per-point labels (TP + concurrency) clutter the chart; the
-    // per-line hardware labels (on by default) are the primary annotation.
-    return false;
-  });
-  const [logScale, setLogScale] = useState(() => getUrlParam('i_log') === '1');
-  // Parallelism labels default off (?i_advlabel=1 overrides on).
-  const [useAdvancedLabels, setUseAdvancedLabels] = useState(
-    () => getUrlParam('i_advlabel') === '1',
+  const labelScenarioKind = sequenceKind(effectiveSequence);
+  const initialLabelState = useMemo(
+    () =>
+      resolveLabelState('fixed-seq', {
+        i_label: getUrlParam('i_label'),
+        i_nolabel: getUrlParam('i_nolabel'),
+        i_advlabel: getUrlParam('i_advlabel'),
+        i_linelabel: getUrlParam('i_linelabel'),
+      }),
+    [getUrlParam],
   );
+  const [showPointLabels, setShowPointLabels] = useState(initialLabelState.showPointLabels);
+  const [logScale, setLogScale] = useState(() => getUrlParam('i_log') === '1');
+  const [useAdvancedLabels, setUseAdvancedLabels] = useState(initialLabelState.useAdvancedLabels);
   const [showGradientLabels, setShowGradientLabels] = useState(
     () => getUrlParam('i_gradlabel') === '1',
   );
-  // Line labels default on (?i_linelabel=0 overrides off).
-  const [showLineLabels, setShowLineLabels] = useState(() => getUrlParam('i_linelabel') !== '0');
+  const [showLineLabels, setShowLineLabels] = useState(initialLabelState.showLineLabels);
   const [showSpeedOverlay, setShowSpeedOverlay] = useState(() => getUrlParam('i_speed') === '1');
   const [showMinecraftOverlay, setShowMinecraftOverlay] = useState(
     () => getUrlParam('i_mc') === '1',
@@ -540,6 +535,19 @@ export function InferenceProvider({
     setTrackedConfigs((prev) => (prev.length > 0 ? [] : prev));
   }, [selectedModel, effectiveSequence, effectivePrecisions, selectedYAxisMetric]);
 
+  useEffect(() => {
+    if (!sequenceResolved) return;
+    const labelState = resolveLabelState(labelScenarioKind, {
+      i_label: getUrlParam('i_label'),
+      i_nolabel: getUrlParam('i_nolabel'),
+      i_advlabel: getUrlParam('i_advlabel'),
+      i_linelabel: getUrlParam('i_linelabel'),
+    });
+    setShowPointLabels(labelState.showPointLabels);
+    setUseAdvancedLabels(labelState.useAdvancedLabels);
+    setShowLineLabels(labelState.showLineLabels);
+  }, [labelScenarioKind, sequenceResolved, getUrlParam]);
+
   // Reconcile the x-axis mode with the scenario kind:
   //  - On mount with no `i_xmode` URL param: snap to the kind's natural default
   //    (interactivity for both agentic and fixed-sequence scenarios). The state was initialized
@@ -1034,6 +1042,12 @@ export function InferenceProvider({
     return [...activeHwTypes].toSorted().join(',');
   }, [activeHwTypes, hwTypesWithData]);
 
+  const serializedLabelState = serializeLabelState(labelScenarioKind, {
+    showPointLabels,
+    useAdvancedLabels,
+    showLineLabels,
+  });
+
   useUrlStateSync(
     {
       i_metric: selectedYAxisMetric,
@@ -1043,17 +1057,17 @@ export function InferenceProvider({
       i_dstart: selectedDateRange.startDate,
       i_dend: selectedDateRange.endDate,
       i_optimal: hideNonOptimal ? '' : '0',
-      i_label: showPointLabels ? '1' : '',
+      i_label: serializedLabelState.i_label,
       i_hc: highContrast ? '1' : '',
       i_log: logScale ? '1' : '',
       i_xmetric: selectedXAxisMetric || '',
       i_e2e_xmetric: selectedE2eXAxisMetric || '',
       i_xmode: selectedXAxisMode,
       i_scale: scaleType,
       i_legend: isLegendExpanded ? '' : '0',
-      i_advlabel: useAdvancedLabels ? '1' : '',
+      i_advlabel: serializedLabelState.i_advlabel,
       i_gradlabel: showGradientLabels ? '1' : '',
-      i_linelabel: showLineLabels ? '' : '0',
+      i_linelabel: serializedLabelState.i_linelabel,
       i_speed: showSpeedOverlay ? '1' : '',
       i_mc: showMinecraftOverlay ? '1' : '',
       i_active: iActiveStr,
diff --git a/packages/app/src/components/inference/utils/label-defaults.test.ts b/packages/app/src/components/inference/utils/label-defaults.test.ts
@@ -0,0 +1,78 @@
+import { describe, expect, it } from 'vitest';
+
+import { resolveLabelState, serializeLabelState } from './label-defaults';
+
+describe('resolveLabelState', () => {
+  it('uses uncluttered fixed-sequence defaults', () => {
+    expect(resolveLabelState('fixed-seq', {})).toEqual({
+      showPointLabels: false,
+      useAdvancedLabels: false,
+      showLineLabels: true,
+    });
+  });
+
+  it('uses parallelism labels instead of line labels for agentic scenarios', () => {
+    expect(resolveLabelState('agentic', {})).toEqual({
+      showPointLabels: true,
+      useAdvancedLabels: true,
+      showLineLabels: false,
+    });
+  });
+
+  it('preserves explicit and legacy URL overrides', () => {
+    expect(
+      resolveLabelState('agentic', {
+        i_nolabel: '1',
+        i_advlabel: '0',
+        i_linelabel: '1',
+      }),
+    ).toEqual({
+      showPointLabels: false,
+      useAdvancedLabels: false,
+      showLineLabels: true,
+    });
+  });
+});
+
+describe('serializeLabelState', () => {
+  it('omits the scenario defaults', () => {
+    expect(serializeLabelState('agentic', resolveLabelState('agentic', {}))).toEqual({
+      i_label: '',
+      i_advlabel: '',
+      i_linelabel: '',
+    });
+  });
+
+  it('serializes deviations from agentic defaults', () => {
+    expect(
+      serializeLabelState('agentic', {
+        showPointLabels: false,
+        useAdvancedLabels: false,
+        showLineLabels: true,
+      }),
+    ).toEqual({
+      i_label: '0',
+      i_advlabel: '0',
+      i_linelabel: '1',
+    });
+  });
+
+  it('preserves fixed-sequence defaults and serializes their deviations', () => {
+    expect(serializeLabelState('fixed-seq', resolveLabelState('fixed-seq', {}))).toEqual({
+      i_label: '',
+      i_advlabel: '',
+      i_linelabel: '',
+    });
+    expect(
+      serializeLabelState('fixed-seq', {
+        showPointLabels: true,
+        useAdvancedLabels: true,
+        showLineLabels: false,
+      }),
+    ).toEqual({
+      i_label: '1',
+      i_advlabel: '1',
+      i_linelabel: '0',
+    });
+  });
+});
diff --git a/packages/app/src/components/inference/utils/label-defaults.ts b/packages/app/src/components/inference/utils/label-defaults.ts
@@ -0,0 +1,45 @@
+import type { ScenarioKind } from '@/lib/data-mappings';
+
+export interface LabelState {
+  showPointLabels: boolean;
+  useAdvancedLabels: boolean;
+  showLineLabels: boolean;
+}
+
+type LabelUrlParams = Partial<
+  Record<'i_label' | 'i_nolabel' | 'i_advlabel' | 'i_linelabel', string>
+>;
+
+export function resolveLabelState(kind: ScenarioKind, params: LabelUrlParams): LabelState {
+  const agentic = kind === 'agentic';
+
+  let showPointLabels = agentic;
+  if (params.i_nolabel === '1' || params.i_label === '0') showPointLabels = false;
+  else if (params.i_label === '1') showPointLabels = true;
+  else if (params.i_advlabel === '1') showPointLabels = true;
+
+  return {
+    showPointLabels,
+    useAdvancedLabels:
+      params.i_advlabel === '1' ? true : params.i_advlabel === '0' ? false : agentic,
+    showLineLabels:
+      params.i_linelabel === '1' ? true : params.i_linelabel === '0' ? false : !agentic,
+  };
+}
+
+export function serializeLabelState(kind: ScenarioKind, state: LabelState): LabelUrlParams {
+  const defaults = resolveLabelState(kind, {});
+
+  return {
+    i_label:
+      state.showPointLabels === defaults.showPointLabels ? '' : state.showPointLabels ? '1' : '0',
+    i_advlabel:
+      state.useAdvancedLabels === defaults.useAdvancedLabels
+        ? ''
+        : state.useAdvancedLabels
+          ? '1'
+          : '0',
+    i_linelabel:
+      state.showLineLabels === defaults.showLineLabels ? '' : state.showLineLabels ? '1' : '0',
+  };
+}
