feat(inference): known-issue warning boxes for affected configs#439
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0a4c2b7. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
UI-only disclosure and export comments from a static, tested issue list; no changes to auth, APIs, or benchmark computation.
Overview
Adds known upstream issue disclosure for specific inference benchmark configs (e.g. GB300 Dynamo TRT MTP FP4 and MI355X MoRI SGLang MTP on DeepSeek R1), driven by a new
known-issuesregistry andmatchKnownConfigIssuesagainst visible chart points (including unofficial overlay series where applicable).Scatter and GPU timeline charts gain an SVG known-issues layer: stacked amber warning boxes (linked to GitHub issues), series-colored arrows to affected data, legend-aware positioning, zoom redraw, and
inference_known_issue_clickedanalytics so warnings appear in PNG exports.CSV export now accepts optional
#comment notes before the header; chart export stamps matching warnings for the same visible series as the on-chart annotations.Reviewed by Cursor Bugbot for commit 2e0e554. Bugbot is set up for automated code reviews on this repo. Configure here.