From 99f53ffdeefc65fac3694735c2379653f2f12bfd Mon Sep 17 00:00:00 2001 From: adibarra <93070681+adibarra@users.noreply.github.com> Date: Thu, 11 Jun 2026 15:26:06 -0500 Subject: [PATCH 1/2] fix: wrong precision on known issue --- packages/app/src/lib/known-issues.test.ts | 8 ++++---- packages/app/src/lib/known-issues.ts | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/app/src/lib/known-issues.test.ts b/packages/app/src/lib/known-issues.test.ts index 4b92f786..96ad84cd 100644 --- a/packages/app/src/lib/known-issues.test.ts +++ b/packages/app/src/lib/known-issues.test.ts @@ -5,17 +5,17 @@ import { KNOWN_CONFIG_ISSUES, knownIssueCsvNote, matchKnownConfigIssues } from ' const DSR1 = 'DeepSeek-R1-0528'; describe('matchKnownConfigIssues', () => { - it('matches the GB300 Dynamo TRT MTP entry for DeepSeek R1 FP4', () => { + it('matches the GB300 Dynamo TRT MTP entry for DeepSeek R1 FP8', () => { const issues = matchKnownConfigIssues(DSR1, [ - { hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp4' }, + { hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp8' }, ]); expect(issues).toHaveLength(1); expect(issues[0].url).toBe('https://github.com/NVIDIA/srt-slurm/issues/51'); }); - it('does not match GB300 Dynamo TRT MTP for non-FP4 precisions', () => { + it('does not match GB300 Dynamo TRT MTP for non-FP8 precisions', () => { const issues = matchKnownConfigIssues(DSR1, [ - { hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp8' }, + { hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp4' }, ]); expect(issues).toHaveLength(0); }); diff --git a/packages/app/src/lib/known-issues.ts b/packages/app/src/lib/known-issues.ts index 828216ca..e948877d 100644 --- a/packages/app/src/lib/known-issues.ts +++ b/packages/app/src/lib/known-issues.ts @@ -29,7 +29,7 @@ export const KNOWN_CONFIG_ISSUES: KnownConfigIssue[] = [ { hwKey: 'gb300_dynamo-trt_mtp', model: Model.DeepSeek_R1, - precisions: ['fp4'], + precisions: ['fp8'], summary: 'Accuracy issues', filed: 'Apr 21, 2026', url: 'https://github.com/NVIDIA/srt-slurm/issues/51', From 1e696cd402c93a36a14fd5f9b335488194bb293c Mon Sep 17 00:00:00 2001 From: adibarra <93070681+adibarra@users.noreply.github.com> Date: Thu, 11 Jun 2026 15:27:42 -0500 Subject: [PATCH 2/2] chore: update related test --- packages/app/src/lib/known-issues.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/app/src/lib/known-issues.test.ts b/packages/app/src/lib/known-issues.test.ts index 96ad84cd..16981cac 100644 --- a/packages/app/src/lib/known-issues.test.ts +++ b/packages/app/src/lib/known-issues.test.ts @@ -47,8 +47,8 @@ describe('matchKnownConfigIssues', () => { it('returns each issue at most once even with many matching points', () => { const issues = matchKnownConfigIssues(DSR1, [ - { hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp4' }, - { hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp4' }, + { hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp8' }, + { hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp8' }, { hwKey: 'mi355x_mori-sglang_mtp', precision: 'fp4' }, ]); expect(issues).toHaveLength(2);