Skip to content

fix: update precision for known issue warning #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adibarra merged 2 commits into from
Jun 11, 2026
Merged

fix: update precision for known issue warning #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99f53ff
fix: wrong precision on known issue
adibarra Jun 11, 2026
1e696cd
chore: update related test
adibarra Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/app/src/lib/known-issues.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@ import { KNOWN_CONFIG_ISSUES, knownIssueCsvNote, matchKnownConfigIssues } from '
const DSR1 = 'DeepSeek-R1-0528';

describe('matchKnownConfigIssues', () => {
it('matches the GB300 Dynamo TRT MTP entry for DeepSeek R1 FP4', () => {
it('matches the GB300 Dynamo TRT MTP entry for DeepSeek R1 FP8', () => {
const issues = matchKnownConfigIssues(DSR1, [
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp4' },
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp8' },
]);
expect(issues).toHaveLength(1);
expect(issues[0].url).toBe('https://github.com/NVIDIA/srt-slurm/issues/51');
});

it('does not match GB300 Dynamo TRT MTP for non-FP4 precisions', () => {
it('does not match GB300 Dynamo TRT MTP for non-FP8 precisions', () => {
const issues = matchKnownConfigIssues(DSR1, [
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp8' },
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp4' },
]);
expect(issues).toHaveLength(0);
});
Expand Down Expand Up @@ -47,8 +47,8 @@ describe('matchKnownConfigIssues', () => {

it('returns each issue at most once even with many matching points', () => {
const issues = matchKnownConfigIssues(DSR1, [
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp4' },
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp4' },
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp8' },
{ hwKey: 'gb300_dynamo-trt_mtp', precision: 'fp8' },
{ hwKey: 'mi355x_mori-sglang_mtp', precision: 'fp4' },
]);
expect(issues).toHaveLength(2);
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/lib/known-issues.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const KNOWN_CONFIG_ISSUES: KnownConfigIssue[] = [
{
hwKey: 'gb300_dynamo-trt_mtp',
model: Model.DeepSeek_R1,
precisions: ['fp4'],
precisions: ['fp8'],
summary: 'Accuracy issues',
filed: 'Apr 21, 2026',
url: 'https://github.com/NVIDIA/srt-slurm/issues/51',
Expand Down
Loading