From 35789e4decfd8be115b1f5273933339982f2952a Mon Sep 17 00:00:00 2001 From: adibarra <93070681+adibarra@users.noreply.github.com> Date: Thu, 11 Jun 2026 22:53:47 -0500 Subject: [PATCH] feat(constants): render atom-disagg as Mooncake ATOM framework --- .../constants/src/framework-aliases.test.ts | 25 +++++++++++++++++++ packages/constants/src/framework-aliases.ts | 2 ++ packages/db/src/etl/normalizers.test.ts | 11 ++++++++ 3 files changed, 38 insertions(+) diff --git a/packages/constants/src/framework-aliases.test.ts b/packages/constants/src/framework-aliases.test.ts index b2212d28..ef2c2f00 100644 --- a/packages/constants/src/framework-aliases.test.ts +++ b/packages/constants/src/framework-aliases.test.ts @@ -2,15 +2,30 @@ import { describe, expect, it } from 'vitest'; import { FRAMEWORK_ALIASES, + FRAMEWORK_LABELS, resolveFrameworkAlias, resolveFrameworkAliasesInString, } from './framework-aliases'; +describe('FRAMEWORK_LABELS', () => { + it('labels the canonical mooncake-atom framework "Mooncake ATOM¹"', () => { + expect(FRAMEWORK_LABELS['mooncake-atom']).toBe('Mooncake ATOM¹'); + }); + + it('labels the atom-disagg alias with its canonical label', () => { + expect(FRAMEWORK_LABELS['atom-disagg']).toBe('Mooncake ATOM¹'); + }); +}); + describe('FRAMEWORK_ALIASES', () => { it('maps sglang-disagg to mori-sglang with disagg=true', () => { expect(FRAMEWORK_ALIASES['sglang-disagg']).toEqual({ canonical: 'mori-sglang', disagg: true }); }); + it('maps atom-disagg to mooncake-atom with disagg=true', () => { + expect(FRAMEWORK_ALIASES['atom-disagg']).toEqual({ canonical: 'mooncake-atom', disagg: true }); + }); + it('maps trtllm to trt', () => { expect(FRAMEWORK_ALIASES['trtllm']).toEqual({ canonical: 'trt' }); }); @@ -29,6 +44,10 @@ describe('resolveFrameworkAlias', () => { expect(resolveFrameworkAlias('dynamo-trtllm')).toBe('dynamo-trt'); }); + it('resolves atom-disagg to mooncake-atom', () => { + expect(resolveFrameworkAlias('atom-disagg')).toBe('mooncake-atom'); + }); + it('is case-insensitive', () => { expect(resolveFrameworkAlias('SGLANG-DISAGG')).toBe('mori-sglang'); expect(resolveFrameworkAlias('Dynamo-TRTllm')).toBe('dynamo-trt'); @@ -54,6 +73,12 @@ describe('resolveFrameworkAliasesInString', () => { ); }); + it('replaces atom-disagg in a config key', () => { + expect(resolveFrameworkAliasesInString('dsv4-fp4-mi355x-atom-disagg')).toBe( + 'dsv4-fp4-mi355x-mooncake-atom', + ); + }); + it('returns string unchanged when no aliases match', () => { expect(resolveFrameworkAliasesInString('dsr1-fp8-h200-trt')).toBe('dsr1-fp8-h200-trt'); }); diff --git a/packages/constants/src/framework-aliases.ts b/packages/constants/src/framework-aliases.ts index cc5eb6b4..378ee0c0 100644 --- a/packages/constants/src/framework-aliases.ts +++ b/packages/constants/src/framework-aliases.ts @@ -9,6 +9,7 @@ export const FW_REGISTRY: Record = { 'dynamo-sglang': { label: 'Dynamo SGLang' }, 'dynamo-trt': { label: 'Dynamo TRT' }, 'dynamo-vllm': { label: 'Dynamo vLLM' }, + 'mooncake-atom': { label: 'Mooncake ATOM¹' }, 'mori-sglang': { label: 'MoRI SGLang' }, sglang: { label: 'SGLang' }, trt: { label: 'TRT' }, @@ -26,6 +27,7 @@ export const SPEC_METHOD_KEYS = new Set(['mtp', 'none']); * Single source of truth — consumed by ETL, frontend, and changelog processing. */ export const FRAMEWORK_ALIASES: Record = { + 'atom-disagg': { canonical: 'mooncake-atom', disagg: true }, 'sglang-disagg': { canonical: 'mori-sglang', disagg: true }, trtllm: { canonical: 'trt' }, 'dynamo-trtllm': { canonical: 'dynamo-trt' }, diff --git a/packages/db/src/etl/normalizers.test.ts b/packages/db/src/etl/normalizers.test.ts index e424e5b2..e569143a 100644 --- a/packages/db/src/etl/normalizers.test.ts +++ b/packages/db/src/etl/normalizers.test.ts @@ -204,6 +204,17 @@ describe('normalizeFramework', () => { }); }); + it('normalizes atom-disagg to mooncake-atom + disagg=true', () => { + expect(normalizeFramework('atom-disagg', false)).toEqual({ + framework: 'mooncake-atom', + disagg: true, + }); + expect(normalizeFramework('ATOM-DISAGG', false)).toEqual({ + framework: 'mooncake-atom', + disagg: true, + }); + }); + it('renames dynamo-trtllm to dynamo-trt and forces disagg=true (framework implies it)', () => { expect(normalizeFramework('dynamo-trtllm', false)).toEqual({ framework: 'dynamo-trt',