fix(inference): link single-run changelog to its producing run, not the date#464
Merged
adibarra merged 1 commit intoJun 15, 2026
Conversation
…he date The Config Changelog's single-run date block rendered date-level Git Commit and Workflow Run links (`data.changelogs.at(-1).head_ref` and `data.runs.at(-1).html_url`): the last entry/run on the calendar date, regardless of config. When two unrelated PRs merged the same day, a config whose data came from the earlier run showed the later run's commit/run links next to its own correct changelog description. Drive the links off the run that actually produced the selected config's data (the sole `dataRunsForDate` entry, the same source the multi-run branch uses) and drop the date-level `headRef`/`runUrl` fields entirely so the bad attribution cannot recur. Both branches now share a `renderRunLinks` helper, and the single-run separator renders only when a link exists (no dangling em-dash when a changelog entry has no matching benchmark run). Fixes SemiAnalysisAI#408
|
@eicherseiji is attempting to deploy a commit to the SemiAnalysisAI Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #408.
Problem
On the inference page's Config Changelog, the "Git Commit" and "Workflow Run" links for a single-run date could point to a completely unrelated run. Reproduced on dsv4-pro 1k1k b200 vllm fp4: the 2026-06-05 entry shows the correct description ("Enable EPLB for DEP configs", PR SemiAnalysisAI/InferenceX#1655) but links to the Qwen3.5 run and commit (PR SemiAnalysisAI/InferenceX#1669) that merged ~30 minutes later the same day.
Root cause: the single-run render branch sourced its links from date-level aggregates in
useComparisonChangelogs:data.changelogs.at(-1)?.head_refanddata.runs.at(-1)?.html_url. Those are the last changelog entry and last run on the calendar date, with no regard for which config produced the point. When two unrelated PRs merge the same day, the later one wins those fields. The description is correctly filtered per config, so the right note shows next to the wrong commit/run.Fix
runs[0]fromdataRunsForDate, the same per-(run, config) source the multi-run branch already uses).headRef/runUrlfields fromComparisonChangelogentirely so the config-blind aggregate cannot be used again. Nothing else read them.renderRunLinkshelper used by both branches.Testing
pnpm typecheck,pnpm lint,pnpm fmtclean.pnpm --filter @semianalysisai/inferencex-app exec vitest run).Note
Low Risk
Scoped inference changelog UI and hook typing; no auth, data writes, or API changes—main risk is incorrect links if run enumeration regresses.
Overview
Fixes wrong Git Commit / Workflow Run links on single-run Config Changelog rows when multiple unrelated workflows landed the same calendar day. Descriptions were already config-filtered, but links came from date-level “last changelog / last run” aggregates.
Data model:
ComparisonChangelogno longer exposes date-levelheadRef/runUrl;useComparisonChangelogsstops populating them. Per-run metadata stays onComparisonRunand benchmarkrunConfigs.UI: The single-run branch takes
headRef/runUrlfrom the run that produced the selected config (runs[0]viarunMetaFor/dataRunsForDate), matching the multi-run path. SharedrenderRunLinksreplaces duplicated anchor JSX. The em dash and link block render only when at least one link exists (avoids a dangling separator when the producing run has no URL/SHA).Tests: Comment on
dataRunsForDateclarifies why per-runhtml_url/head_shamust flow through for this fix.Reviewed by Cursor Bugbot for commit 0f9388a. Bugbot is set up for automated code reviews on this repo. Configure here.