fix(inference): resolve framework aliases in getHardwareKey#465
Merged
Conversation
… ATOMesh data renders
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Small, localized change to chart key normalization, consistent with existing alias handling elsewhere in chart-utils; low risk beyond inference chart filtering behavior.
Overview
getHardwareKeynow runs aggregated benchmark framework strings throughresolveFrameworkAliasbefore building GPU keys, matchingbuildAvailabilityHwKeyused for the chart GPU filter.That fixes disaggregated ATOMesh runs that still report
atom-disagg: chart points resolve to keys likemi355x_mooncake-atominstead of mismatched raw names, so they are no longer dropped from the chart. Plainatomstays separate from the aliased disagg name. Tests cover the alias and the non-aliased case.Reviewed by Cursor Bugbot for commit 3db90fe. Bugbot is set up for automated code reviews on this repo. Configure here.