Skip to content

fix(inference): resolve framework aliases in getHardwareKey#465

Merged
adibarra merged 1 commit into
masterfrom
fix/atomesh-hwkey-alias
Jun 16, 2026
Merged

fix(inference): resolve framework aliases in getHardwareKey#465
adibarra merged 1 commit into
masterfrom
fix/atomesh-hwkey-alias

Conversation

@adibarra

@adibarra adibarra commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Small, localized change to chart key normalization, consistent with existing alias handling elsewhere in chart-utils; low risk beyond inference chart filtering behavior.

Overview
getHardwareKey now runs aggregated benchmark framework strings through resolveFrameworkAlias before building GPU keys, matching buildAvailabilityHwKey used for the chart GPU filter.

That fixes disaggregated ATOMesh runs that still report atom-disagg: chart points resolve to keys like mi355x_mooncake-atom instead of mismatched raw names, so they are no longer dropped from the chart. Plain atom stays separate from the aliased disagg name. Tests cover the alias and the non-aliased case.

Reviewed by Cursor Bugbot for commit 3db90fe. Bugbot is set up for automated code reviews on this repo. Configure here.

@adibarra adibarra marked this pull request as ready for review June 16, 2026 13:58
@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
inferencemax-app Ready Ready Preview, Comment Jun 16, 2026 1:58pm

Request Review

@adibarra adibarra merged commit 3f1b944 into master Jun 16, 2026
9 checks passed
@adibarra adibarra deleted the fix/atomesh-hwkey-alias branch June 16, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant