fix(inference): scope accuracy notices to the specific affected runs#467
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Display-only change to when accuracy warnings appear; behavior is covered by new unit tests and does not touch auth or data pipelines.
Overview
Known-config accuracy warnings no longer blanket every point on a hardware/precision combo; they apply only to chart points whose GitHub Actions run id is listed on the issue (or to all runs when
affectedRunsis omitted).known-issuesgains optionalaffectedRuns, optionalrun_urlon matchable points,runIdFromRunUrl(parses/runs/<id>, ignores/attempts), and sharedpointMatchesIssueused bymatchKnownConfigIssuesand byGPUGraph/ScatterGraphwhen choosing which points get warning arrows. GB300 Dynamo TRT MTP (FP8) and MI355X MoRI SGLang MTP (FP4) entries are wired to their specific bad runs. Tests were expanded around run-scoped vs unscoped matching.Reviewed by Cursor Bugbot for commit c081168. Bugbot is set up for automated code reviews on this repo. Configure here.